Files icon indicating copy to clipboard operation
Files copied to clipboard

Add ui for creating and deleting tags

Open yaira2 opened this issue 1 year ago • 1 comments

This issue is open for discussion. image

  • Should the UI for creating tag have its own dialog or should it be part of settings?
  • Should you be able to right click the tags section on the sidebar to create a new tag or should you have to open the manage tags UI and do it from there?

yaira2 avatar Jul 19 '22 19:07 yaira2

Adding a new tag option in the tag management page and the context menu would proberly be best. Some properly would expect it to work like a library and other would in the dialog/settings.

Josh65-2201 avatar Jul 22 '22 00:07 Josh65-2201

I think it doesn't matter. As long as this feature comes. In the current version, the labels cannot be customized. Is this a special problem for me or I don't understand if this feature is closed?

sercanserdar avatar Jan 12 '23 06:01 sercanserdar

I think the right-click option is the best. We already have a lot of settings and I don't think we should keep overcrowding them. Maybe we can add two different user interfaces:

  • New tag
    • A simple, small modal that allows you to quickly create a tag (choose color and name);
  • Manage tags
    • A settings-like modal where you can create, edit, and remove tags. Renaming tags could work as inline renaming. I'm not sure, but I'd like a count of tagged files (e.g. Red: 30 tags).

ferrariofilippo avatar Jan 19 '23 21:01 ferrariofilippo

I think it'll have to be part of settings because users can already hide the sidebar section.

yaira2 avatar Jan 19 '23 22:01 yaira2

I think it'll have to be part of settings because users can already hide the sidebar section.

I was thinking of the righ click option because of this: if the user hides Tag Section it won't probably use tags so she/he doesn't need that setting

ferrariofilippo avatar Jan 19 '23 22:01 ferrariofilippo

Based on the open pull request shouldn't there be a new page in settings for tags rather then having the context menu option in Appearance and the editing/creating in Advanced. I think it would make it less hidden and crowded.

Josh65-2201 avatar Feb 11 '23 15:02 Josh65-2201

I temporarily created it in Advanced to follow requirements, but I think a new page would make sense

Add a list under experimental settings for adding/deleting tags

ferrariofilippo avatar Feb 11 '23 16:02 ferrariofilippo

We will move them to a new page in the near future, I want some time to test the changes before officially making tags a supported feature.

yaira2 avatar Feb 12 '23 00:02 yaira2