Files
Files copied to clipboard
files-community
Feature: Use different icon to indicate whether the Recycle Bin is empty or not.
What's the Problem?
To know if the Recycle Bin is empty or not, you have to open it, or open its contextual menu.
Solution/Idea
You can add information about the item from the Recycle Bin to favorites. This can be done in many ways: different icon, bold text, number of items in parentheses when there are any, or any different style.
Requirements
- Use different icon to indicate whether recycle bin is empty or full
Thank you for your feedback, we're currently tracking this in #1089. Keeping this open as well.
@yaichenbaum has this been superseded by #1089 or is it still open for pull requests? To keep things clean just thinking making it bold under the favorites when theres items in the recycle bin, adding the number of items in parenthesis would look out of place
#1089 is just to group these issues together, the proper solution is to use different icons to highlight the status.
Understood, so changing the text or text weight is not the recommended approach?
A PR that was implementing this issue has been made, but removed for limitation issues regarding the current implementation.
A few things to keep in mind for the next person implementing the feature:
- There are several scenarios where the icon needs to be reevaluated:
When files are deleted into the recycle bin When files are being restored in the recycle bin When files are being deleted from the recycle bin When the recycle bin is entirely restored or empty
- The icons should be taken from
Constants.ImageRes. - The indexes for the
Constants.ImageResare namelypublic const int RecycleBin = 54andpublic const int EmptyRecycleBin = 55.
