Files icon indicating copy to clipboard operation
Files copied to clipboard

Feature: Add progress ring to properties when calculating sizes

Open Josh65-2201 opened this issue 3 years ago • 3 comments

What's the Problem?

There used to be a loading icon when sizes were calculated which now doesnt appear and causes some confusion. See #8585

Requirements

  • Display progress ring next to the size labels to indicate when they are still loading

Files Version

2.1.15.0

Windows Version

No response

Comments

No response

Josh65-2201 avatar Mar 06 '22 00:03 Josh65-2201

Is it really needed? The size itself acts as a loading indicator since it keeps updating.

yaira2 avatar Mar 06 '22 02:03 yaira2

for larger folders it does end up stoping seeming like its done if the user doesnt rember or know that the bytes will show when its actually done

Josh65-2201 avatar Mar 06 '22 10:03 Josh65-2201

@yaichenbaum We better indicate if the calculation is in progress.

  1. It is possible that the calculation seems to stop but then resumes. For example if the calculation in progress examines a subfolder that contains many very small files and the size given is an order of magnitude larger.
  2. If the displayed size comes from the cache, it is never decreased until the calculation is finished (only increased). This is a current limitation that should be fixed when the cache is persistent. But even in this case, the calculation may take a moment before detecting a subfolder whose size has changed.

cinqmilleans avatar Mar 06 '22 15:03 cinqmilleans

I was reading through the code and found out that we actually have a size progress bar in Files.App.Views.PropertiesGeneral.xaml (Line @ 195). There are two main problems with it:

  • The first is that its width is set to 0, but this can easily be solved by setting HorizontalAlignement="Stretch";
  • The second issue is that we can only know how many folders we have already counted, not their total. So, how can we handle the progress? Should it change with time? Should it have a fixed value?

ferrariofilippo avatar Jan 03 '23 12:01 ferrariofilippo

It was just a spinning loading icon before with no fixed value should probably be the same.

Josh65-2201 avatar Jan 03 '23 19:01 Josh65-2201