Files
Files copied to clipboard
Feature: Add progress ring to properties when calculating sizes
What's the Problem?
There used to be a loading icon when sizes were calculated which now doesnt appear and causes some confusion. See #8585
Requirements
- Display progress ring next to the size labels to indicate when they are still loading
Files Version
2.1.15.0
Windows Version
No response
Comments
No response
Is it really needed? The size itself acts as a loading indicator since it keeps updating.
for larger folders it does end up stoping seeming like its done if the user doesnt rember or know that the bytes will show when its actually done
@yaichenbaum We better indicate if the calculation is in progress.
- It is possible that the calculation seems to stop but then resumes. For example if the calculation in progress examines a subfolder that contains many very small files and the size given is an order of magnitude larger.
- If the displayed size comes from the cache, it is never decreased until the calculation is finished (only increased). This is a current limitation that should be fixed when the cache is persistent. But even in this case, the calculation may take a moment before detecting a subfolder whose size has changed.
I was reading through the code and found out that we actually have a size progress bar in Files.App.Views.PropertiesGeneral.xaml (Line @ 195).
There are two main problems with it:
- The first is that its width is set to
0, but this can easily be solved by settingHorizontalAlignement="Stretch"; - The second issue is that we can only know how many folders we have already counted, not their total. So, how can we handle the progress? Should it change with time? Should it have a fixed value?
It was just a spinning loading icon before with no fixed value should probably be the same.