Files icon indicating copy to clipboard operation
Files copied to clipboard

Feature: Add setting to makes delete permanently delete items by default

Open Battler624 opened this issue 3 years ago • 14 comments

Description

Files are undeletable if I turn off "show a confirmation dialogue when deleting files" but I still get a green checkmark for the operation.

Steps To Reproduce

Go to recycle bin click on properties. turn on "dont move files to recycle bin" go to files app turn off the "show a confirmation dialogue" in preferences try to delete a file

Expected behavior

File gets deleted

Files Version

Version: 2.0.34.0 OS Version: 10.0.22000.376

Windows Version

Edition Windows 11 Pro Version 21H2 Installed on ‎06/‎11/‎2021 OS build 22000.376 Experience Windows Feature Experience Pack 1000.22000.376.0

Relevant Assets/Logs

Example of the deletion process on files compared to files explorer https://youtu.be/cCRKiRlO4HI

The ongoing tasks section with the green checkmark. https://i.imgur.com/9WbyiEM.png

Battler624 avatar Dec 20 '21 19:12 Battler624

Using Shift+Delete should work as a workaround.

gave92 avatar Dec 21 '21 08:12 gave92

Can confirm

Battler624 avatar Dec 21 '21 08:12 Battler624

This issue should be resolved with #7500

yaira2 avatar Jan 08 '22 23:01 yaira2

Not sure if its right to re-open this but its up to you or I can create a new issue.

While this is fixed, I now get a confirmation to delete even when confirmations are disabled.

https://i.imgur.com/92eqy1j.png

https://i.imgur.com/q1L1R01.png

Battler624 avatar Jan 12 '22 03:01 Battler624

Yeah, behavior was changed so that if recycle bin is turned off you'll get confirmation, unless you press "Shift+Delete". This is because currently we can't distinguish between a drive where the user disabled the recyclebin from a drive that does not have recyclebin to begin with (e.g removable drives or network drives). I believe Explorer removes confirmation only in the first case.

Edit: perhaps we get the infp from this key -> HKEY_CURRENT_USER\SOFTWARE\Microsoft\Windows\CurrentVersion\Explorer\BitBucket\Volume

gave92 avatar Jan 12 '22 07:01 gave92

Yeah, behavior was changed so that if recycle bin is turned off you'll get confirmation, unless you press "Shift+Delete". This is because currently we can't distinguish between a drive where the user disabled the recyclebin from a drive that does not have recyclebin to begin with (e.g removable drives or network drives). I believe Explorer removes confirmation only in the first case.

Edit: perhaps we get the infp from this key -> HKEY_CURRENT_USER\SOFTWARE\Microsoft\Windows\CurrentVersion\Explorer\BitBucket\Volume

The whole point is that I dont want confirmation when deleting files and I dont need recycle bin, I have no idea why this has to be hard.

Battler624 avatar Jan 12 '22 11:01 Battler624

Cause if you delete a file thinking it's going to the bin but instead it gets permanently deleted without warning you're not gonna be happy.

Guess the simple alternative is to add an option called "always delete files permanently" in addition to the one for displaying confirmation.

@yaichenbaum any thoughts?

gave92 avatar Jan 12 '22 12:01 gave92

I wouldn't mind this at all.

Battler624 avatar Jan 12 '22 12:01 Battler624

Cause if you delete a file thinking it's going to the bin but instead it gets permanently deleted without warning you're not gonna be happy.

Guess the simple alternative is to add an option called "always delete files permanently" in addition to the one for displaying confirmation.

@yaichenbaum any thoughts?

Personally, I use the ctrl + shift + delete shortcut for that, but this can be useful for touch users. I'm hesitant to add something that can cause data loss like this since most users expect items to go to recycle bin.

yaira2 avatar Jan 12 '22 15:01 yaira2

Cause if you delete a file thinking it's going to the bin but instead it gets permanently deleted without warning you're not gonna be happy.

Guess the simple alternative is to add an option called "always delete files permanently" in addition to the one for displaying confirmation.

@yaichenbaum any thoughts?

Personally, I use the ctrl + shift + delete shortcut for that, but this can be useful for touch users. I'm hesitant to add something that can cause data loss like this since most users expect items to go to recycle bin.

As an option? Do people really fuck up simple stuff like this?

Battler624 avatar Jan 12 '22 15:01 Battler624

image I lost count on how many people asked for help after uninstalling Files without turning this setting off.

yaira2 avatar Jan 12 '22 16:01 yaira2

image

I lost count on how many people asked for help after uninstalling Files without turning this setting off.

Then perhaps instead of settings make this only found in the config file?

Battler624 avatar Jan 12 '22 16:01 Battler624

That sounds reasonable

yaira2 avatar Jan 12 '22 17:01 yaira2

If you do, can you please update this issue ? Much thanks

Battler624 avatar Jan 12 '22 17:01 Battler624

Is this still an issue?

Josh65-2201 avatar Nov 27 '22 16:11 Josh65-2201

I think it's already fixed

hecksmosis avatar Nov 27 '22 19:11 hecksmosis

I just checked and no its not fixed.

Battler624 avatar Dec 14 '22 22:12 Battler624

This was implemented in v2.4.33

yaira2 avatar Feb 14 '23 07:02 yaira2