Files icon indicating copy to clipboard operation
Files copied to clipboard

Published 20 hours ago • verified publisher icon files-community

Bug: Turning off grouping can show an empty view

Open nvi9 opened this issue 3 years ago • 10 comments

Explain the bug

When grouping (implemented in #4826) is turned on and the user clicks on a header to show the group names only and then turns off grouping the view becomes empty.

To reproduce

  1. Go to any folder
  2. Click on Arrangement options
  3. Select any grouping type (eg. Name)
  4. Click on a group header
  5. Click on Arrangement options again
  6. Select None in the Group by options
  7. See the error (empty view)

Expected behavior

The original folder view should be restored when Group by > None is being selected.

Screenshots

image image

System Information

  • OS Version: Windows 10 20H2 19042.985
  • App version: 2.3.11.0

Additional comment

This is not an issue when the folder contents were visible, not just the group headers.

nvi9 avatar May 24 '21 15:05 nvi9

By the way sorry for my misunderstanding, but how did you find this feature? I have no idea running the version 1.5.0. I even look up the Release notes and couldn't find any mentions about it.

ghost avatar May 24 '21 16:05 ghost

By the way sorry for my misunderstanding, but how did you find this feature? I have no idea running the version 1.5.0. I even look up the Release notes and couldn't find any mentions about it.

@LukoFoks This feature has yet to be released, and can only be found by building the source code from main.

winston-de avatar May 24 '21 17:05 winston-de

Looks like it is necessary to call ToggleActiveView (to turn off zoom mode) when IsSourceGrouped is set to false. Either in the DetailsLayoutBrowser config or somewhere here https://github.com/files-community/Files/blob/main/Files/ViewModels/ItemViewModel.cs#L657. (Sorry, i'm new to this project)

MarkBirkholz avatar Oct 04 '21 19:10 MarkBirkholz

@nvi9 is this still an issue in v2.1.13?

yaira2 avatar Feb 16 '22 16:02 yaira2

@nvi9 is this still an issue in v2.1.13?

@yaichenbaum yes it is

nvi9 avatar Feb 16 '22 16:02 nvi9

Is this still an issue in 2.3.11.0 or above?

Josh65-2201 avatar Sep 08 '22 19:09 Josh65-2201

Is this still an issue in 2.3.11.0 or above?

@Josh-65 with version 2.3.11.0, yes

Edit: just checked version 2.3.28.0 and the issue is still present there.

nvi9 avatar Sep 09 '22 08:09 nvi9

@nvi9 I don't whink that's a bug: that view shows you the existing groups and how many items they contain. If you turn off grouping there are no more groups so that page is empty. Anyway, if you want to remove that empty page, I think we might add an entry saying: All x items, or we could simply navigate one page back

ferrariofilippo avatar Sep 09 '22 09:09 ferrariofilippo

It should default to showing the items as normal with grouping none

Josh65-2201 avatar Sep 09 '22 09:09 Josh65-2201

I should have fixed this. If you can confirm, I'll proceed with code cleanup

ferrariofilippo avatar Sep 09 '22 14:09 ferrariofilippo