App crashes when opening a lot of tabs

[R3voA3]

trafficstars

App crashes when too many tabs are opened quickly by holding CTRL + T.

Reproduceabilty: ~80%

debug_fulltrust.txt debug.txt

[issue-label-bot[bot]]

Issue-Label Bot is automatically applying the label bug to this issue, with a confidence of 0.98. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

[yaira2]

This issue appears to be resolved in main.

[lukeblevins]

Reopening to track potential regressions here after #4209

[Josh65-2201]

Is this still an issue in 2.3.11.0 or above?

[yaira2]

Yes

[QuaintMako]

The crash seems to only happen when using the keyboard accelerator. Tried to open 40 tabs at the same time using another path of call. Reducing the accelerator to "one press = one use" should do the trick.

[yaira2]

Seems like a reasonable solution, I think we do something similar with the back/forward buttons.

[QuaintMako]

Are you talking about those accelerators?

[yaira2]

It might have actually been the refresh button but similar idea.

[QuaintMako]

@gave92 the work done in #10648 doesn't seem to fix that issue for me. Is there some work left to do on the basis of it?

[gave92]

Could be, as I could never reproduce the issue in the first place. But I expected #10648 to have the same effect as #10385 (wait until a tab has been opened before adding the next tab). Does #10385 fix the issue if applied on current main?

[QuaintMako]

#10385 does not seem to solve the crash entirely anymore. If anything, it makes the issue a lot less worse.

Instead of crashing after 1 tab on main when holding the shortcut, it crashes after ~70 tabs for me. Better, but still not a fix.

I'm closing #10385 to investigate a better solution.

[yaira2]

@QuaintMako I opened an issue to track your idea for solving this #11737.