Files icon indicating copy to clipboard operation
Files copied to clipboard
verified publisher icon files-community

Fix: Fixed thumbails not loading in MTP devices

Open gave92 opened this issue 11 months ago • 4 comments

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

  • Closes #15084

Added back some code removed in #14423 which is necessary for loading thumbails in MTP.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Verify that icons are loaded in MTP devices
  2. Verify that loading on normal drives is not impacted

gave92 avatar Feb 05 '25 22:02 gave92

I was thinking we could take this a step forward with a single method in FileThumbnailHelper that would first attempt using the Win32 method, and StorageItem as a fallback.

yaira2 avatar Feb 06 '25 21:02 yaira2

Ok now thumbnails work in file list, in properties window and preview pane 💪

gave92 avatar Feb 09 '25 14:02 gave92

I'm concerned about maintaining two separate thumbnail systems (we did in the past, with much trouble). Is there anything we can do with Win32Helper.GetIcon and avoid the need to use StorageThumbnail?

yaira2 avatar Mar 10 '25 14:03 yaira2

I'm concerned about maintaining two separate thumbnail systems (we did in the past, with much trouble). Is there anything we can do with Win32Helper.GetIcon and avoid the need to use StorageThumbnail?

@gave92 this is potentially solvable when we switch ShellViewModel to the new storage abstractions.

yaira2 avatar Apr 23 '25 21:04 yaira2