Files icon indicating copy to clipboard operation
Files copied to clipboard

Feature: Remove expander button calculate folder size setting in settings

Open Lamparter opened this issue 1 year ago • 4 comments

What feature or improvement do you think would benefit Files?

Currently, the "Calculate folder size" setting in the app settings has an expander to show or hide the info bar that displays a warning.

Image

This is simply unnecessary in my opinion, as the info bar control is tiny and the user has no interest in closing or opening it.

Requirements

  • Hide expander button calculate folder size setting in settings

Files Version

3.7.7.0

Windows Version

10.0.22631.4317

Comments

No response

Lamparter avatar Oct 15 '24 18:10 Lamparter

I don't think it does really matter to Files. We can't show the InfoBar inside the Settings card. AFAIK the WCT one also can't. I really wonder it worth taking a look.

0x5bfa avatar Oct 15 '24 18:10 0x5bfa

I'm not opposed to hiding the button, but the expander control is the best way to group the banner with the setting.

yaira2 avatar Oct 15 '24 19:10 yaira2

Yes I agree.

Lamparter avatar Oct 15 '24 19:10 Lamparter

Let's go ahead with this

yaira2 avatar Oct 15 '24 19:10 yaira2

@Lamparter to clarify, the expected behavior is to keep the expander but to hide the expand button.

yaira2 avatar Dec 11 '24 14:12 yaira2

It appears that the entire expander header functions as a single button, and there isn't currently a way to remove the button using a custom style. For now, we'll keep the control as it is. However, we can revisit this issue if we transition to the Toolkit Setting control.

yaira2 avatar Dec 24 '24 19:12 yaira2