Files icon indicating copy to clipboard operation
Files copied to clipboard
verified publisher icon files-community

GitHub: Update copyright span

Open Lamparter opened this issue 1 year ago • 8 comments

Resolved / Related Issues

  • Related: #16083

Lamparter avatar Aug 26 '24 15:08 Lamparter

@0x5bfa how did you edit the licence header in the resource script when you did in #14933 46716e9?

Lamparter avatar Aug 26 '24 15:08 Lamparter

I was thinking of getting rid of copyright year. This work is hard for the reviewer to review. And once we did so, we don't have to touch here every year.

0x5bfa avatar Aug 26 '24 17:08 0x5bfa

@Lamparter can you create a pr that only removes license year?

0x5bfa avatar Aug 26 '24 19:08 0x5bfa

I was thinking of getting rid of copyright year. This work is hard for the reviewer to review. And once we did so, we don't have to touch here every year.

@0x5bfa do you want me to just make it 2018-present?

Lamparter avatar Aug 26 '24 19:08 Lamparter 

// Copyright (c) 2018-2024 Files Community
// Licensed under the MIT License. See the LICENSE.

Please revert any other changes.

0x5bfa avatar Aug 26 '24 22:08 0x5bfa

@0x5bfa 'See the LICENSE.' is grammatically incorrect. I recommend 'See the license file', 'See the license file in the root directory' or even just remove the 'See the license' sentence altogether

Lamparter avatar Aug 27 '24 08:08 Lamparter

Let's remove.

0x5bfa avatar Aug 27 '24 09:08 0x5bfa

@0x5bfa @yaira2 I cannot resolve the merge conflicts, the editor just says Access denied: only those with write access to this repository can resolve these conflicts.

Lamparter avatar Aug 29 '24 14:08 Lamparter

Create a new pr or fix that on your local with GitHub desktop.

0x5bfa avatar Aug 29 '24 20:08 0x5bfa

Oops, GitHub automatically closed since I wiped the PR clean of commit history. @0x5bfa I'm still working on this though.

Lamparter avatar Sep 04 '24 20:09 Lamparter

@yaira2 do you not have a CODEOWNERS file?

Lamparter avatar Sep 04 '24 21:09 Lamparter

Please just do replacing only. Otherwise, the PR would look suspicious because this has a lot of changes and GitHub diff doesnt show all of them.

  • Revert .gitignore file's changes
  • Revert any addition or deletion not regarding updating 2024 to 2018-2024 and removing See the LICENSE.

do you not have a CODEOWNERS file?

No.

0x5bfa avatar Sep 05 '24 04:09 0x5bfa

I think I should close this - I initially opened this PR because I was worried about the law but I have come to realise that I'm really stupid this PR is absolutely unnecessary.

Lamparter avatar Sep 19 '24 17:09 Lamparter

Probably someone or I do this when it becomes 2025. I assume there aren't motivation to take an immediate action for this.

0x5bfa avatar Sep 19 '24 17:09 0x5bfa

Yeah.

Lamparter avatar Sep 19 '24 17:09 Lamparter