Files icon indicating copy to clipboard operation
Files copied to clipboard

Bug: Google Drive doesn't show in Cloud Drives when mounts as a folder

Open kohyung opened this issue 1 year ago • 9 comments

Description

Google Drive didn't show up in Cloud Drives Sidebar, Dropbox & Onedrive got no problem. screenshot-1719384747145

Steps To Reproduce

Just new install already like that. screenshot-1719384747145

Requirements

New installation already like that. screenshot-1719384747145

Files Version

3.5.0.0

Windows Version

10.0.19045.4529

Log File

debug.log

kohyung avatar Jun 26 '24 06:06 kohyung

Thanks for the report. Have you set up the desktop client, opened it and restarted Files from the system tray?

Josh65-2201 avatar Jun 26 '24 11:06 Josh65-2201

Hi, pls refer to the attachment, I have tried a few times.

On Wed, Jun 26, 2024 at 7:14 PM Josh65-2201 @.***> wrote:

Thanks for the report. Have you set up the desktop client, opened it and restarted Files from the system tray?

— Reply to this email directly, view it on GitHub https://github.com/files-community/Files/issues/15698#issuecomment-2191438031, or unsubscribe https://github.com/notifications/unsubscribe-auth/APU7TPJHLLHP3JAU2QUWAQTZJKPB5AVCNFSM6AAAAABJ5HKXDGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJRGQZTQMBTGE . You are receiving this because you authored the thread.Message ID: @.***>

kohyung avatar Jun 26 '24 12:06 kohyung

Email attachments don't work. You will have to click the View on GitHub link at the bottom of the email > Copy and paste or click the add attachment button to select the file > Wait until you don't see uploading in the text > Click the green comment button.

Josh65-2201 avatar Jun 26 '24 13:06 Josh65-2201

Hi, pls refer to the attachment, I have tried a few times. screenshot-1719404309390

kohyung avatar Jun 26 '24 13:06 kohyung

Can you send a screenshot of the full Windows File Explorer window on This PC

Josh65-2201 avatar Jun 26 '24 14:06 Josh65-2201

Screenshot 2024-06-26 22 33 00

kohyung avatar Jun 26 '24 14:06 kohyung

Need a screenshot from Windows File Explorer, not Files.

Josh65-2201 avatar Jun 26 '24 14:06 Josh65-2201

Screenshot 2024-06-26 22 37 44

kohyung avatar Jun 26 '24 14:06 kohyung

We don't support Google Drive mounting as a folder instead of a dedicate drive currently.

@Josh65-2201 To detect the mounting point of Google Drive properly, we need to inspect the value of PerAccountPreferences in HKEY_CURRENT_USER\Software\Google\DriveFS from the Windows Registry.

Marking it as a good first issue as the fix should be trivial:

  1. Read the value of PerAccountPreferences from HKEY_CURRENT_USER\Software\Google\DriveFS
  2. Parse the value as json
  3. Read per_account_preferences as an array and add all items in to the sidebar, the path to Google Drive is saved in mount_point_path

/cc: @yaira2

hez2010 avatar Jun 27 '24 16:06 hez2010

Hello, I would like to try to work on this if that is okay. I think I found the place in the source code where I would need to make changes, and I plan to start working on it tomorrow. I am aware of the contributing guidelines and will follow them.

wharvex avatar Jul 02 '24 01:07 wharvex

Thank you! Please reach out if you have any questions.

yaira2 avatar Jul 02 '24 01:07 yaira2

No problem! I made some progress on exploring the problem today (see the notification above about the commit I just made in a scratch repo that references this issue), and I'm hoping to submit a pull request sometime this weekend.

wharvex avatar Jul 04 '24 21:07 wharvex

@kohyung we've resolved the issue in our development branch, and it will be included in the next update. Huge shoutout to @wharvex for contributing this fix.

yaira2 avatar Aug 14 '24 04:08 yaira2