Files Code Quality: Generative resource management and refactoring

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

From #15504

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

Generated Strings properties from keys in primary Resources file
Compatible import from .resw and .json file

Jun 24 '24 13:06 XTorLukas

Getting a similar error. I have created conda env with Python 3.10, but pipx is somehow getting my system installed python ( 3.9.18) ERROR: Package 'fabric' requires a different Python: 3.9.18 not in '<3.13,>=3.10'

Jun 02 '24 02:06 ewre324

Try under WSL: conda create -n fabric python=3.11 conda activate fabric cd fabric pipx install . fabric --setup

Jun 02 '24 04:06 TomWest61

Try under WSL: conda create -n fabric python=3.11 conda activate fabric cd fabric pipx install . fabric --setup

Thanks for the help. I am on Linux but I tried the same steps.

Jun 02 '24 06:06 ewre324

I'm under linux (Ubuntu 20)

tried also with conda -n fabric python=3.11

Same error:

ERROR: Ignored the following versions that require a different python version: 0.1.14 Requires-Python >=3.9,<4.0; 0.1.15 Requires-Python >=3.9,<4.0; 0.1.16 Requires-Python >=3.9,<4.0; 0.1.17 Requires-Python >=3.9,<4.0; 0.1.23 Requires-Python >=3.9,<4.0; 0.1.24 Requires-Python >=3.9,<4.0; 0.1.32 Requires-Python >=3.9,<4.0; 0.10.0 Requires-Python >=3.10,<4.0; 0.11.0 Requires-Python >=3.10,<4.0; 0.11.1 Requires-Python >=3.10,<4.0; 0.11.2 Requires-Python >=3.10,<4.0; 0.14.0 Requires-Python >=3.10,<=3.13; 0.14.0rc0 Requires-Python >=3.10,<3.12; 0.14.0rc1 Requires-Python >=3.10,<=3.13; 0.14.1 Requires-Python >=3.10,<=3.13; 0.14.3 Requires-Python >=3.10,<=3.13; 0.14.4 Requires-Python >=3.10,<=3.13; 0.16.0 Requires-Python >=3.10,<=3.13; 0.16.1 Requires-Python >=3.10,<=3.13; 0.16.2 Requires-Python >=3.10,<=3.13; 0.16.3 Requires-Python >=3.10,<=3.13; 0.17.0 Requires-Python >=3.10,<=3.13; 0.17.0rc0 Requires-Python >=3.10,<=3.13; 0.17.0rc1 Requires-Python >=3.10,<=3.13; 0.17.0rc2 Requires-Python >=3.10,<=3.13; 0.19.0 Requires-Python >=3.10,<=3.13; 0.22.0 Requires-Python >=3.10,<=3.13; 0.22.2 Requires-Python >=3.10,<=3.13; 0.22.3 Requires-Python >=3.10,<=3.13; 0.22.4 Requires-Python >=3.10,<=3.13; 0.22.5 Requires-Python >=3.10,<=3.13; 0.27.0 Requires-Python <=3.13,>=3.10; 0.27.0rc0 Requires-Python <=3.13,>=3.10; 0.27.0rc1 Requires-Python <=3.13,>=3.10; 0.27.0rc2 Requires-Python <=3.13,>=3.10; 0.27.0rc3 Requires-Python <=3.13,>=3.10; 0.27.1 Requires-Python <=3.13,>=3.10; 0.27.2 Requires-Python <=3.13,>=3.10; 0.28.0 Requires-Python <=3.13,>=3.10; 0.28.1 Requires-Python <=3.13,>=3.10; 0.28.2 Requires-Python <=3.13,>=3.10; 0.28.3 Requires-Python <=3.13,>=3.10; 0.28.4 Requires-Python <=3.13,>=3.10; 0.28.5 Requires-Python <=3.13,>=3.10; 0.28.6 Requires-Python <=3.13,>=3.10; 0.28.7 Requires-Python <=3.13,>=3.10; 0.28.8 Requires-Python <=3.13,>=3.10; 0.28.9rc1 Requires-Python <=3.13,>=3.10; 0.28.9rc2 Requires-Python <=3.13,>=3.10; 0.30.0 Requires-Python <=3.13,>=3.10; 0.30.0rc1 Requires-Python <=3.13,>=3.10; 0.30.0rc2 Requires-Python <=3.13,>=3.10; 0.30.0rc3 Requires-Python <=3.13,>=3.10; 0.30.0rc4 Requires-Python <=3.13,>=3.10; 0.30.0rc5 Requires-Python <=3.13,>=3.10; 0.30.0rc6 Requires-Python <=3.13,>=3.10; 0.30.0rc7 Requires-Python <=3.13,>=3.10; 0.30.10 Requires-Python <=3.13,>=3.10; 0.30.11 Requires-Python <=3.13,>=3.10; 0.30.4 Requires-Python <=3.13,>=3.10; 0.30.5 Requires-Python <=3.13,>=3.10; 0.30.8 Requires-Python <=3.13,>=3.10; 0.5.0 Requires-Python >=3.9,<4.0; 0.5.2 Requires-Python >=3.10,<4.0; 0.5.3 Requires-Python >=3.10,<4.0; 0.5.5 Requires-Python >=3.10,<4.0
ERROR: Could not find a version that satisfies the requirement crewai<0.23.0,>=0.22.5 (from fabric) (from versions: 0.1.0, 0.1.1, 0.1.2, 0.1.3, 0.1.5, 0.1.6, 0.1.7)
ERROR: No matching distribution found for crewai<0.23.0,>=0.22.5
'/home/jmeireles/.local/pipx/venvs/bin/python -m pip install . -q' failed

Jun 02 '24 18:06 zmeireles

The .python-version file in the main branch is buggered up. I simply did.

> echo "3.11.9" > .python-version

and it worked.

Hmm.. Python version dependancy is already handled in pyproject.toml. I'd just remove the file all together, it's un-needed.

Jun 03 '24 14:06 bdmorin

Wow I also tinkerered with pyproject.toml but this skipped my mind. Thanks @bdmorin

Jun 03 '24 14:06 ewre324

I've done all the above and even created my own Python 3.12 environment and I still get the following errors running on Ubuntu 20.04 PRO:

(myenv) gjmcginn@optiplex990:~/bin/fabric$ python --version
Python 3.12.3
(myenv) gjmcginn@optiplex990:~/bin/fabric$ pipx install .
ERROR: Ignored the following versions that require a different python version: 0.1.14 Requires-Python >=3.9,<4.0; 0.1.15 Requires-Python >=3.9,<4.0; 0.1.16 Requires-Python >=3.9,<4.0; 0.1.17 Requires-Python >=3.9,<4.0; 0.1.23 Requires-Python >=3.9,<4.0; 0.1.24 Requires-Python >=3.9,<4.0; 0.1.32 Requires-Python >=3.9,<4.0; 0.10.0 Requires-Python >=3.10,<4.0; 0.11.0 Requires-Python >=3.10,<4.0; 0.11.1 Requires-Python >=3.10,<4.0; 0.11.2 Requires-Python >=3.10,<4.0; 0.14.0 Requires-Python >=3.10,<=3.13; 0.14.0rc0 Requires-Python >=3.10,<3.12; 0.14.0rc1 Requires-Python >=3.10,<=3.13; 0.14.1 Requires-Python >=3.10,<=3.13; 0.14.3 Requires-Python >=3.10,<=3.13; 0.14.4 Requires-Python >=3.10,<=3.13; 0.16.0 Requires-Python >=3.10,<=3.13; 0.16.1 Requires-Python >=3.10,<=3.13; 0.16.2 Requires-Python >=3.10,<=3.13; 0.16.3 Requires-Python >=3.10,<=3.13; 0.17.0 Requires-Python >=3.10,<=3.13; 0.17.0rc0 Requires-Python >=3.10,<=3.13; 0.17.0rc1 Requires-Python >=3.10,<=3.13; 0.17.0rc2 Requires-Python >=3.10,<=3.13; 0.19.0 Requires-Python >=3.10,<=3.13; 0.22.0 Requires-Python >=3.10,<=3.13; 0.22.2 Requires-Python >=3.10,<=3.13; 0.22.3 Requires-Python >=3.10,<=3.13; 0.22.4 Requires-Python >=3.10,<=3.13; 0.22.5 Requires-Python >=3.10,<=3.13; 0.27.0 Requires-Python <=3.13,>=3.10; 0.27.0rc0 Requires-Python <=3.13,>=3.10; 0.27.0rc1 Requires-Python <=3.13,>=3.10; 0.27.0rc2 Requires-Python <=3.13,>=3.10; 0.27.0rc3 Requires-Python <=3.13,>=3.10; 0.27.1 Requires-Python <=3.13,>=3.10; 0.27.2 Requires-Python <=3.13,>=3.10; 0.28.0 Requires-Python <=3.13,>=3.10; 0.28.1 Requires-Python <=3.13,>=3.10; 0.28.2 Requires-Python <=3.13,>=3.10; 0.28.3 Requires-Python <=3.13,>=3.10; 0.28.4 Requires-Python <=3.13,>=3.10; 0.28.5 Requires-Python <=3.13,>=3.10; 0.28.6 Requires-Python <=3.13,>=3.10; 0.28.7 Requires-Python <=3.13,>=3.10; 0.28.8 Requires-Python <=3.13,>=3.10; 0.28.9rc1 Requires-Python <=3.13,>=3.10; 0.28.9rc2 Requires-Python <=3.13,>=3.10; 0.30.0 Requires-Python <=3.13,>=3.10; 0.30.0rc1 Requires-Python <=3.13,>=3.10; 0.30.0rc2 Requires-Python <=3.13,>=3.10; 0.30.0rc3 Requires-Python <=3.13,>=3.10; 0.30.0rc4 Requires-Python <=3.13,>=3.10; 0.30.0rc5 Requires-Python <=3.13,>=3.10; 0.30.0rc6 Requires-Python <=3.13,>=3.10; 0.30.0rc7 Requires-Python <=3.13,>=3.10; 0.30.10 Requires-Python <=3.13,>=3.10; 0.30.11 Requires-Python <=3.13,>=3.10; 0.30.4 Requires-Python <=3.13,>=3.10; 0.30.5 Requires-Python <=3.13,>=3.10; 0.30.8 Requires-Python <=3.13,>=3.10; 0.5.0 Requires-Python >=3.9,<4.0; 0.5.2 Requires-Python >=3.10,<4.0; 0.5.3 Requires-Python >=3.10,<4.0; 0.5.5 Requires-Python >=3.10,<4.0
ERROR: Could not find a version that satisfies the requirement crewai<0.23.0,>=0.22.5 (from fabric) (from versions: 0.1.0, 0.1.1, 0.1.2, 0.1.3, 0.1.5, 0.1.6, 0.1.7)
ERROR: No matching distribution found for crewai<0.23.0,>=0.22.5
'/home/gjmcginn/.local/pipx/venvs/bin/python -m pip install . -q' failed
(myenv) gjmcginn@optiplex990:~/bin/fabric$

Jun 08 '24 15:06 GeorgeMcGinn

with pyenv global set to 3.12 same issue

lukasz@fikus88-PC:~/fabric$ pyenv global 3.12
lukasz@fikus88-PC:~/fabric$ pipx install .
ERROR: Ignored the following versions that require a different python version: 0.1.14 Requires-Python >=3.9,<4.0; 0.1.15 Requires-Python >=3.9,<4.0; 0.1.16 Requires-Python >=3.9,<4.0; 0.1.17 Requires-Python >=3.9,<4.0; 0.1.23 Requires-Python >=3.9,<4.0; 0.1.24 Requires-Python >=3.9,<4.0; 0.1.32 Requires-Python >=3.9,<4.0; 0.10.0 Requires-Python >=3.10,<4.0; 0.11.0 Requires-Python >=3.10,<4.0; 0.11.1 Requires-Python >=3.10,<4.0; 0.11.2 Requires-Python >=3.10,<4.0; 0.14.0 Requires-Python >=3.10,<=3.13; 0.14.0rc0 Requires-Python >=3.10,<3.12; 0.14.0rc1 Requires-Python >=3.10,<=3.13; 0.14.1 Requires-Python >=3.10,<=3.13; 0.14.3 Requires-Python >=3.10,<=3.13; 0.14.4 Requires-Python >=3.10,<=3.13; 0.16.0 Requires-Python >=3.10,<=3.13; 0.16.1 Requires-Python >=3.10,<=3.13; 0.16.2 Requires-Python >=3.10,<=3.13; 0.16.3 Requires-Python >=3.10,<=3.13; 0.17.0 Requires-Python >=3.10,<=3.13; 0.17.0rc0 Requires-Python >=3.10,<=3.13; 0.17.0rc1 Requires-Python >=3.10,<=3.13; 0.17.0rc2 Requires-Python >=3.10,<=3.13; 0.19.0 Requires-Python >=3.10,<=3.13; 0.22.0 Requires-Python >=3.10,<=3.13; 0.22.2 Requires-Python >=3.10,<=3.13; 0.22.3 Requires-Python >=3.10,<=3.13; 0.22.4 Requires-Python >=3.10,<=3.13; 0.22.5 Requires-Python >=3.10,<=3.13; 0.27.0 Requires-Python <=3.13,>=3.10; 0.27.0rc0 Requires-Python <=3.13,>=3.10; 0.27.0rc1 Requires-Python <=3.13,>=3.10; 0.27.0rc2 Requires-Python <=3.13,>=3.10; 0.27.0rc3 Requires-Python <=3.13,>=3.10; 0.27.1 Requires-Python <=3.13,>=3.10; 0.27.2 Requires-Python <=3.13,>=3.10; 0.28.0 Requires-Python <=3.13,>=3.10; 0.28.1 Requires-Python <=3.13,>=3.10; 0.28.2 Requires-Python <=3.13,>=3.10; 0.28.3 Requires-Python <=3.13,>=3.10; 0.28.4 Requires-Python <=3.13,>=3.10; 0.28.5 Requires-Python <=3.13,>=3.10; 0.28.6 Requires-Python <=3.13,>=3.10; 0.28.7 Requires-Python <=3.13,>=3.10; 0.28.8 Requires-Python <=3.13,>=3.10; 0.28.9rc1 Requires-Python <=3.13,>=3.10; 0.28.9rc2 Requires-Python <=3.13,>=3.10; 0.30.0 Requires-Python <=3.13,>=3.10; 0.30.0rc1 Requires-Python <=3.13,>=3.10; 0.30.0rc2 Requires-Python <=3.13,>=3.10; 0.30.0rc3 Requires-Python <=3.13,>=3.10; 0.30.0rc4 Requires-Python <=3.13,>=3.10; 0.30.0rc5 Requires-Python <=3.13,>=3.10; 0.30.0rc6 Requires-Python <=3.13,>=3.10; 0.30.0rc7 Requires-Python <=3.13,>=3.10; 0.30.10 Requires-Python <=3.13,>=3.10; 0.30.11 Requires-Python <=3.13,>=3.10; 0.30.4 Requires-Python <=3.13,>=3.10; 0.30.5 Requires-Python <=3.13,>=3.10; 0.30.8 Requires-Python <=3.13,>=3.10; 0.5.0 Requires-Python >=3.9,<4.0; 0.5.2 Requires-Python >=3.10,<4.0; 0.5.3 Requires-Python >=3.10,<4.0; 0.5.5 Requires-Python >=3.10,<4.0
ERROR: Could not find a version that satisfies the requirement crewai<0.23.0,>=0.22.5 (from fabric) (from versions: 0.1.0, 0.1.1, 0.1.2, 0.1.3, 0.1.5, 0.1.6, 0.1.7)
ERROR: No matching distribution found for crewai<0.23.0,>=0.22.5
'/home/lukasz/.local/pipx/venvs/bin/python -m pip install . -q' failed
lukasz@fikus88-PC:~/fabric$ python --version
Python 3.12.4
lukasz@fikus88-PC:~/fabric$

lukasz@fikus88-PC:~/fabric$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 20.04.2 LTS
Release:        20.04
Codename:       focal
lukasz@fikus88-PC:~/fabric$

Jun 12 '24 14:06 fikus88

I tried Create a conda env (if not already done)

conda create -n fabric
conda activate fabric

then : pipx install . --python=python3

It looks like it's working as everything gets installed with no error message. BUT it still doesn't work as the fabric command is not recognized in the shell even after closing/reopening it.

I ended up building a dockerized version following the steps here : https://github.com/danielmiessler/fabric/pull/327

Aug 02 '24 13:08 ReversedK