Files
Files copied to clipboard
Code Quality: Creating a language helper to work with the global language of the application
Resolved / Related Issues
To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.
- Closes #15440
Steps used to test these changes
Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.
- Work globaly correct
Jajx, how easy it is to inadvertently close a PR 😅
@hishitetsu thanks for the reminder, I forgot to format the file. Yes the PR is still a draft, but after the last edits it will be ready and I will be able to change the PR status
So far everything seems to be fine
- Load defult correctly
- Load selected en-US correctly
Should I replace all occurrences with ApplicationLanguages.PrimaryLanguageOverride with this helper?
/format
✅ Successfully formatted XAML files.
OMG, it still works well! they did great work.
I don't like uncommented classes with their properties and methods, the comments serve to better understand what the part does, why that part is still misunderstood. Yes it takes longer, but it saves a lot of time in the future.