Files icon indicating copy to clipboard operation
Files copied to clipboard

Code Quality: Creating a language helper to work with the global language of the application

Open XTorLukas opened this issue 1 year ago • 4 comments

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

  • Closes #15440

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Work globaly correct

XTorLukas avatar May 22 '24 01:05 XTorLukas

Jajx, how easy it is to inadvertently close a PR 😅

XTorLukas avatar May 22 '24 09:05 XTorLukas

@hishitetsu thanks for the reminder, I forgot to format the file. Yes the PR is still a draft, but after the last edits it will be ready and I will be able to change the PR status

XTorLukas avatar May 22 '24 15:05 XTorLukas

So far everything seems to be fine

  • Load defult correctly image
  • Load selected en-US correctly image image

XTorLukas avatar May 22 '24 16:05 XTorLukas

Should I replace all occurrences with ApplicationLanguages.PrimaryLanguageOverride with this helper?

XTorLukas avatar May 22 '24 16:05 XTorLukas

/format

yaira2 avatar May 23 '24 16:05 yaira2

✅ Successfully formatted XAML files.

OMG, it still works well! they did great work.

0x5bfa avatar May 23 '24 16:05 0x5bfa

I don't like uncommented classes with their properties and methods, the comments serve to better understand what the part does, why that part is still misunderstood. Yes it takes longer, but it saves a lot of time in the future.

XTorLukas avatar May 23 '24 18:05 XTorLukas