Files icon indicating copy to clipboard operation
Files copied to clipboard

Fix: Fixed an issue where "Custom" is not localized in settings appearance page

Open 0x5bfa opened this issue 1 year ago • 1 comments

Summary

As the title. https://discordapp.com/channels/725513575971684472/1070771912797597917/1236967189815230538

PR Checklist

  • [x] Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
  • [ ] Did you build the app and test your changes?
  • [ ] Did you check for accessibility? You can use Accessibility Insights for this.
  • [ ] Did you remove any strings from the en-us resource file?
    • [ ] Did you search the solution to see if the string is still being used?
  • [ ] Did you implement any design changes to an existing feature?
    • [ ] Was this change approved?
  • [ ] Are there any other steps that were used to validate these changes? None

Screenshots

None

0x5bfa avatar May 06 '24 09:05 0x5bfa

For this PR, we should test the following

  1. Assign a custom background color
  2. Restart the app
  3. Open settings and confirm the "custom" item is selected

yaira2 avatar May 06 '24 14:05 yaira2