Files icon indicating copy to clipboard operation
Files copied to clipboard
verified publisher icon files-community

Code Quality: Use WindowContext instead of AppModel

Open 0x5bfa opened this issue 1 year ago • 5 comments

AppModel was leftover from UWP, removed and replaced with WindowContext which can be DI'd.

0x5bfa avatar May 04 '24 06:05 0x5bfa

For testing, we should test one or two of the properties and ensure they are updated correctly. For example, we should ensure that IsCompactOverlay and IsPasteEnabled are correctly updated when the state changes.

yaira2 avatar May 05 '24 15:05 yaira2

Sorry for making extra change while you finished review. I wanted to make sure reduce App.WindowContext reference.

0x5bfa avatar May 06 '24 08:05 0x5bfa

Now, ready to be merged

0x5bfa avatar May 07 '24 15:05 0x5bfa

I'm not sure why it's fail again and again since I can build, deploy and see that the window successfully opens without any crash.

It's failing here: https://github.com/files-community/Files/blob/cc0a7701c9c2b744136a8f58940463dd769978e1/tests/Files.InteractionTests/Tests/FolderTests.cs#L54

Can you check if you can open New... button on your end?

0x5bfa avatar May 07 '24 18:05 0x5bfa

Try rebasing the branch from main.

yaira2 avatar May 07 '24 21:05 yaira2

@0x5bfa can you try forking these changes to another branch to see if that fixes the CI issues?

yaira2 avatar May 12 '24 17:05 yaira2

Sure.

0x5bfa avatar May 12 '24 17:05 0x5bfa