Files icon indicating copy to clipboard operation
Files copied to clipboard

Code Quality: Removed ContextMenuFlyoutItemViewModelBuilder

Open 0x5bfa opened this issue 1 year ago • 1 comments

Summary

  • ContextMenuFlyoutItemType to ContextFlyoutItemType
  • Removed ContextMenuFlyoutItemViewModelBuilder
  • ContextMenuFlyoutItemViewModel to ContextFlyoutItemModel
  • Added XML comments in ContextFlyoutItemModel
  • Added some constructors to adopt with IRichCommand in ContextFlyoutItemModel

PR Checklist

  • [x] Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers. Close #14761
  • [x] Did you build the app and test your changes?
  • [ ] Did you check for accessibility? You can use Accessibility Insights for this.
  • [ ] Did you remove any strings from the en-us resource file?
    • [ ] Did you search the solution to see if the string is still being used?
  • [ ] Did you implement any design changes to an existing feature?
    • [ ] Was this change approved?
  • [x] Are there any other steps that were used to validate these changes?
    1. Go to layout page
    2. Right click (check if shown correctly)
    3. Select item and right click (check again)
    4. Right click Sidebar item (again)
    5. Go to Home
    6. Right click Widget item (again)

Screenshots

None

0x5bfa avatar May 04 '24 04:05 0x5bfa

This is on my todo list to review

yaira2 avatar May 12 '24 14:05 yaira2

Ready

0x5bfa avatar May 28 '24 14:05 0x5bfa

Messed up. I have to redo everything

0x5bfa avatar Jun 06 '24 18:06 0x5bfa

I can't remember why I did change. Can I recreate a PR and publish step by step?

0x5bfa avatar Jun 06 '24 18:06 0x5bfa

I can't remember why I did change. Can I recreate a PR and publish step by step?

Of course! And if it's easier, we can merge in stages.

yaira2 avatar Jun 06 '24 18:06 yaira2