Files
Files copied to clipboard
Code Quality: Removed ContextMenuFlyoutItemViewModelBuilder
Summary
-
ContextMenuFlyoutItemTypetoContextFlyoutItemType - Removed
ContextMenuFlyoutItemViewModelBuilder -
ContextMenuFlyoutItemViewModeltoContextFlyoutItemModel - Added XML comments in
ContextFlyoutItemModel - Added some constructors to adopt with IRichCommand in
ContextFlyoutItemModel
PR Checklist
- [x] Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers. Close #14761
- [x] Did you build the app and test your changes?
- [ ] Did you check for accessibility? You can use Accessibility Insights for this.
- [ ] Did you remove any strings from the en-us resource file?
- [ ] Did you search the solution to see if the string is still being used?
- [ ] Did you implement any design changes to an existing feature?
- [ ] Was this change approved?
- [x] Are there any other steps that were used to validate these changes?
- Go to layout page
- Right click (check if shown correctly)
- Select item and right click (check again)
- Right click Sidebar item (again)
- Go to Home
- Right click Widget item (again)
Screenshots
None
This is on my todo list to review
Ready
Messed up. I have to redo everything
I can't remember why I did change. Can I recreate a PR and publish step by step?
I can't remember why I did change. Can I recreate a PR and publish step by step?
Of course! And if it's easier, we can merge in stages.