Files icon indicating copy to clipboard operation
Files copied to clipboard

Code Quality: Move Resources dir to Assets

Open 0x5bfa opened this issue 1 year ago • 4 comments

Summary

As the title.

PR Checklist

  • [ ] Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers. Closes #issue
  • [ ] Did you build the app and test your changes?
  • [ ] Did you check for accessibility? You can use Accessibility Insights for this.
  • [ ] Did you remove any strings from the en-us resource file?
    • [ ] Did you search the solution to see if the string is still being used?
  • [ ] Did you implement any design changes to an existing feature?
    • [ ] Was this change approved?
  • [ ] Are there any other steps that were used to validate these changes? None

Screenshots

None

0x5bfa avatar May 01 '24 20:05 0x5bfa

Assets folder is mess and I’d like to get them have this simple structure:

Assets/
 Libraries/ (DLL and EXE files)
 Images/ (icon images)
 Resources/ (reg files and json files)

@yaira2 What do you think?

0x5bfa avatar May 02 '24 07:05 0x5bfa

I usually view Assets as reserved for images and the like.

yaira2 avatar May 02 '24 14:05 yaira2

But those resources are already there except those json files.

the folder will look like after packaged:

Assets/
 AppTiles (app icons, no changes)
 Images (archive logos, fluent icons)
 Libraries (DLL,EXE)
 Resources (reg files, json files)

Current structure doesn’t provide unique folders for each purpose.

https://learn.microsoft.com/en-us/windows/uwp/app-resources/images-tailored-for-scale-theme-contrast#qualify-an-image-resource-for-scale-theme-and-contrast

0x5bfa avatar May 02 '24 21:05 0x5bfa

In the future I want to put 7z DLL files in Libraries dir

0x5bfa avatar May 03 '24 00:05 0x5bfa

For testing, we need to test the features that rely on the moved resources. This includes the details pane and properties window.

yaira2 avatar May 05 '24 03:05 yaira2

I tested these changes (added to the PR description) and I can confirm it's working as expected.

yaira2 avatar May 05 '24 15:05 yaira2