Files
Files copied to clipboard
Code Quality: Remove context flyout builder
Summary
This is also an prepatation PR for the IRichCommand parameter introduction.
In the effort to introduction of IRichCommand parameter, it'd be better to remove duplication and provide single way of generating ContextFlyoutItems.
-
ContextMenuFlyoutItemTypetoContextFlyoutItemType - Removed
ContextMenuFlyoutItemViewModelBuilder -
ContextMenuFlyoutItemViewModeltoContextFlyoutItemModel - Added XML comments in
ContextFlyoutItemModel - Added some constructors to adopt with IRichCommand in
ContextFlyoutItemModel - Converted
OpacityIconModelfrom struct to class to use constructor - ~~Use
IsVisibleinstead ofShowto be more boolean-tic~~ - ~~Removed
IDand useTaginstead.~~
PR Checklist
- [x] Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
- [x] Did you build the app and test your changes?
- [ ] Did you check for accessibility? You can use Accessibility Insights for this.
- [ ] Did you remove any strings from the en-us resource file?
- [ ] Did you search the solution to see if the string is still being used?
- [ ] Did you implement any design changes to an existing feature?
- [ ] Was this change approved?
- [x] Are there any other steps that were used to validate these changes?
- Go to layout page
- Right click (check if shown correctly)
- Select item and right click (check again)
- Right click Sidebar item (again)
- Go to Home
- Right click Widget item (again)
Screenshots
None
Are there any other steps that were used to validate these changes
Done all. Full change log is available in the PR body.
We have two unused boolean properties, removing is out of scope?
ID and SingleItemOnly.
Causing many issues....