Files icon indicating copy to clipboard operation
Files copied to clipboard

Code Quality: Method has overload with cancellation support

Open gumbarros opened this issue 1 year ago • 1 comments

Description

Many methods in the code base supports cancellation and are nothing using the CancellationToken.

Concerned code

<platforms><Files.App>\Services\UpdateService.cs (1 issue) <platforms><Files.App>\Utils\Storage\Search\FolderSearch.cs (3 issues) <platforms><Files.App>\Utils\Archives\CompressArchiveModel.cs (1 issue) <platforms><Files.App>\Services\SideloadUpdateService.cs (1 issue) <platforms><Files.App>\Utils\Storage\StorageItems\VirtualStorageFile.cs (2 issues) <platforms><Files.App>\Utils\Storage\StorageItems\NativeStorageFile.cs (7 issues) <platforms><Files.App>\Utils\Storage\StorageItems\FtpStorageFolder.cs (5 issues) <platforms><Files.App>\Utils\Storage\Operations\FilesystemOperations.cs (29 issues) <platforms><Files.App>\Utils\Storage\StorageItems\SystemStorageFile.cs (8 issues) <platforms><Files.App>\Utils\Storage\StorageItems\ZipStorageFolder.cs (8 issues) <platforms><Files.App>\Utils\Storage\StorageItems\ZipStorageFile.cs (4 issues) <platforms><Files.App>\Utils\Storage\StorageBaseItems\BaseStorageFolder.cs (6 issues) <platforms><Files.App>\Utils\Storage\Operations\FileOperationsHelpers.cs (3 issues) <platforms><Files.App>\Data\Models\ItemViewModel.cs (5 issues) <platforms><Files.App>\Utils\Storage\StorageItems\FtpStorageFile.cs (1 issue) <platforms><Files.App>\Data\Factories\ShellContextFlyoutHelper.cs (1 issue) <platforms><Files.App>\Helpers\Win32\Win32Helper.Storage.cs (2 issues) <platforms><Files.App>\Utils\Git\GitHelpers.cs (3 issues) <platforms><Files.App>\Utils\Storage\StorageItems\StreamWithContentType.cs (2 issues) <platforms><Files.App>\ViewModels\Properties\Items\FolderProperties.cs (1 issue) <platforms><Files.App>\ViewModels\Properties\Items\LibraryProperties.cs (1 issue)

Gains

  • Reliability, if the user cancels an operation, the operation will respond faster because of the CancellationToken

Requirements

  • Passing the CancellationToken in the methods specified by the analyzer

Comments

No response

gumbarros avatar Apr 01 '24 01:04 gumbarros