Bug: Not a folder error when opening recycle bin from shortcut

[ElCunq]

Description

I can't use the app after the last updates. It says "NotAFolder" when I try to open trash bin or ThisPC.

Steps To Reproduce

Restart computer. Try to open trashbin or ThisPC. Get the error.

Requirements

Normally it should open the files but it doesn't open. I can solve it using preview version with it but it's temporary.

Files Version

3.3.0.0

Windows Version

10.0.22631.3296

Log File

debug.log

[Josh65-2201]

Thanks for the report, have you tried reinstalling Files? Make sure to export your settings by going to Files settings > Advanced > Export. then Import your settings from Files settings > Advanced > Import after reinstalling.

[ElCunq]

Thanks for the report, have you tried reinstalling Files? Make sure to export your settings by going to Files settings > Advanced > Export. then Import your settings from Files settings > Advanced > Import after reinstalling.

Yes I tried like 3 or 4 times both stable and preview but it didn't work. Almost all my settings same with standart so I didn't exported them. But I remember I just change preview to acrylic and "set files for default file manager" to on.

[Josh65-2201]

What's shown in the path bar?

[ElCunq]

Shell:RecycleBinFolder and Shell:MyComputerFolder this two Oh and the quick access part on home shows empty with this bug.

[ElCunq]

for again this is the recyclebin

and this is the home screen

[T-i-a-7]

Same problem here.

[ElCunq]

2 weeks later still no progress. That's sad.

[Josh65-2201]

There still hasn't been a way to constantly reproduce this, Only you and T-i-a-7 have reported it. Unfortunately there no error in the log to go off either.

[ElCunq]

I'm using kaspersky as a antivirus. Can it cause to problem? @T-i-a-7 are you using same?

[T-i-a-7]

@ElCunq @Josh65-2201 No, I'm not using it so that is not the problem. I would also like to tell you that I did a clean install of windows (for another reason, not for this problem) and reinstalled Files as well. Guess what?! Everything is fine now: installed the same way, configured the same way, everything the same but now magically it works.

[TCAtrevor]

I am seeing this issue on one computer, but not the other, although I could've sworn it used to be on both. The currently affected computer has a largely filled Recycle Bin and the one no longer having this issue is currently empty. Hope this is relevant. I should've searched this issue sooner to give my feedback.

[Josh65-2201]

Does reinstalling Files on the one showing the dialog fix it?

[ElCunq]

Does reinstalling Files on the one showing the dialog fix it?

Nope it didn't fix it. Actually it made no help. I thought it'll make some fixes but none. 🥲

[ElCunq]

I am seeing this issue on one computer, but not the other, although I could've sworn it used to be on both. The currently affected computer has a largely filled Recycle Bin and the one no longer having this issue is currently empty. Hope this is relevant. I should've searched this issue sooner to give my feedback.

Thanks for the feedback I hope it'll help to solve

[vchalmel]

Hello, I have the same issue here.

Using the "Reinitialize" button from the "Apps & Features" >> "advanced options" control panel "solved" it tho. @ElCunq you could try that after backuping all the app temp & config files and inspect those with the team to find the discrepancy. Maybe they can find where is the issue by restoring favs and configs options one by one.

[justinlosh]

I'm having the same issue, but not much in the debug log with the exception of the following:

2024-06-12 19:28:08.4616|Error|System.ObjectDisposedException: Cannot access a disposed object.
Object name: 'ObjectReference'.
   at WinRT.IObjectReference.ThrowIfDisposed()
   at WinRT.IObjectReference.AsType[T]()
   at WinRT.ExceptionHelpers.GetHRForException(Exception ex)
   at ABI.System.EventHandler`1.Do_Abi_Invoke[TAbi](Void* thisPtr, IntPtr sender, TAbi args)

Afterwards, the "Recycle Bin" shows as "Shell:RecycleBinFolder" in the Pinned file tree.

[ElCunq]

I had to reinstall windows some other problems and it didn't happen again but İ'm scared of it to repeat. I hope it'll be solved soon

[justinlosh]

Yeah, I actually just reinstalled Win 11 a week ago.

[0x5bfa]

the quick access part on home shows empty with this bug.

@ElCunq Let me know what makes you think so?

[0x5bfa]

Thank for you all five people reporting this issue and waiting it to be fixed with great patience.

While Files devs have never been able to reproduce this, what I can tell is enumeration goes wrong without exception but with an unknown error when converting string path (‘Shell:RecycleBinFolder’).

I’m pretty sure this dialog with humanized error code is used only in this place in single method for enumerating inner children:

https://github.com/files-community/Files/blob/31d6fee922223af49bb20fc40e345300641044e9/src/Files.App/Data/Models/ItemViewModel.cs#L1657

This error message is actually ERROR_INVALID_DRIVE error from HResult. ‘NotAFolder’ message isn’t appropriate at all. So I will log to know until next preview build (also next stable is coming soon v3.5).

https://github.com/files-community/Files/blob/31d6fee922223af49bb20fc40e345300641044e9/src/Files.App/Utils/Storage/Helpers/FilesystemTasks.cs#L48

@yaira2 @hishitetsu fyi let me know it’d make us easy to investigate.

When preview build with this modification published, I’d like you all to paste log here.

[hishitetsu]

Is there any possibility of a timeout? https://github.com/files-community/Files/blob/31d6fee922223af49bb20fc40e345300641044e9/src/Files.App/Data/Models/ItemViewModel.cs#L1616

[tw333k]

this started happening to me but when I try to open Network. I've uninstalled/reinstalled but it's still the same. UPDATE: I went to uninstall again so I quit the app. I then realised that I didn't try this so I re-opened it and everything is as it should be! I should have known, every time I post a problem/open a ticket, the problem is immediately solved.

[yaira2]

This appears to be resolved in v3.6.

[TCAtrevor]

This issue is certainly not resolved. I have still received this message on both 3.6 and now 3.7.

[yaira2]

How do you reproduce the bug? I created a shortcut as described and it works fine.

[TCAtrevor]

I'm not sure how it is reproduced. It seems like it's been a mystery for everyone else experiencing it too. I can provide my config if there's any chance that helps, but from my perspective, it's just a random on-and-off issue between my two computers.

[yaira2]

How are you accessing Recycle Bin, via the Sidebar?

[TCAtrevor]

Recycle Bin does not show up on the sidebar for me. I access it from the desktop icon provided by default on Windows.

[T-i-a-7]

@yaira2 As mentioned above, this bug is not currently reproducible. It occurs when the user opens the recycle bin using the icon on the desktop, but for some reason this bug does not happen all the time and for every user. Therefore, it is difficult to reproduce it.

[yaira2]

Is Files set as the default file manager?