Files icon indicating copy to clipboard operation
Files copied to clipboard

Bug: Properties window is opening in the background

Open enoversum opened this issue 7 months ago • 9 comments

Description

When using the current Store version (3.0.1.0), when you open a folder in Files that is empty, then right-clicking a drive and opening the drive properties puts the info window into the background, so the main Files window always stays on top. Even clicking the info window lets it only flash up for a moment, but doesn't bring it to the foreground.

Steps To Reproduce

  1. Open Files.
  2. Go to a folder on your system that has no files or sub-folders inside. Removing files doesn't work, it has to be empty when you enter the folder.
  3. Right-click a drive in the sidebar.
  4. Click 'Properties' ("Eigenschaften" in German).
  5. The popup window opens, but immediately moves behind the main Files window.
  6. Clicking the info window in the background doesn't move it to the foreground.

Requirements

  • Let Files open the Properties window in the foreground and don't steal focus off it.

Files Version

3.0.1.0

Windows Version

23H2 (22635.2700)

Log File

Not needed

enoversum avatar Nov 06 '23 23:11 enoversum

Thank for the report, seems similar to #11432 except the fix that was used there is already in place for the sidebar.

yaira2 avatar Nov 07 '23 00:11 yaira2

@yaira2 Sounds like you already have an idea and a plan on how to fix this ;) .

enoversum avatar Nov 07 '23 00:11 enoversum

The cause of the issue is known but I can't provide a timeline for when this will be addressed.

yaira2 avatar Nov 07 '23 18:11 yaira2

@yaira2 do you know what is the cause of the bug, I am trying to see if i can fix it

ahmedmgamal94 avatar Nov 07 '23 18:11 ahmedmgamal94

The issue is the focus automatically switches back to the main window after the flyout closes. The fix should be to delay opening the window until after the menu is closed.

yaira2 avatar Nov 07 '23 18:11 yaira2

Hi! Can I still try to fix this issue or am I arriving too late? To fix it, should I clone the repository or fork it? Thanks

utarasama avatar Feb 05 '24 13:02 utarasama

The issue is open to anyone still. You will need to make a fork to make a PR

Josh65-2201 avatar Feb 05 '24 13:02 Josh65-2201

Hi, based on your last comment I assume that I can try to fix this issue. Could you please assign it to me and give hints and suggestions which might help me to fix it properly?
@yaira2 I saw your explanation of the fix in one of the comments above, but if it is possible, could you please give more details about it?

SerhiiHarashchenko avatar Feb 23 '24 14:02 SerhiiHarashchenko

@SerhiiHarashchenko We can swiftly fix using my method BringToForegroundEx in Win32Helper class.

0x5bfa avatar May 17 '24 06:05 0x5bfa