Files
Files copied to clipboard
Feature: Added experimental terminal integration
Resolved / Related Issues
- [x] Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers. Closes #6235
Validation How did you test these changes?
- [x] Did you build the app and test your changes?
Screenshots (optional)
I'm wondering if we can use the conhost from Windows Terminal instead of using the WebView-based terminal?
I'd like to but it's huge and I could not find an easy way to integrate it.
What's left to do? Looks solid!
Hey @0x5bfa the TODOs I have in mind are:
- [x] Add setting to enable/disable the feature
- [x] Decide if terminal is global or if each tab has its own instance
- [ ] Add setting to store the preferred terminal
- [ ] Define different terminal themes for light/dark mode
- [ ] Remember terminal size and if it was opened or closed when restarting Files
@gave92 Thank you for using CsWin32! This is our short term goal, which is to use source generator everywhere.
I've added a setting under Experimental to enable/disable the feature (default: off). The feature may be good enough for first release :)
I had some notes on this but I'll have another look since it's been a while.
The main point to figure out before merging is whether the terminal is global, or if there can be a separate terminal for each tab & pane. I lean towards the second option (similar to VS Code).
Holding off while @hez2010 checks if it's possible to use Windows Terminal control.
Added ability to have more than one terminal 😇
Switching between terminals is working nicely!