Files icon indicating copy to clipboard operation
Files copied to clipboard

Feature: Added experimental terminal integration

Open gave92 opened this issue 8 months ago • 17 comments

Resolved / Related Issues

  • [x] Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers. Closes #6235

Validation How did you test these changes?

  • [x] Did you build the app and test your changes?

Screenshots (optional) image

gave92 avatar Nov 01 '23 10:11 gave92

I'm wondering if we can use the conhost from Windows Terminal instead of using the WebView-based terminal?

hez2010 avatar Mar 04 '24 01:03 hez2010

I'd like to but it's huge and I could not find an easy way to integrate it.

gave92 avatar Mar 04 '24 07:03 gave92

What's left to do? Looks solid!

0x5bfa avatar Apr 13 '24 09:04 0x5bfa

Hey @0x5bfa the TODOs I have in mind are:

  • [x] Add setting to enable/disable the feature
  • [x] Decide if terminal is global or if each tab has its own instance
  • [ ] Add setting to store the preferred terminal
  • [ ] Define different terminal themes for light/dark mode
  • [ ] Remember terminal size and if it was opened or closed when restarting Files

gave92 avatar Apr 13 '24 17:04 gave92

@gave92 Thank you for using CsWin32! This is our short term goal, which is to use source generator everywhere.

0x5bfa avatar Apr 22 '24 23:04 0x5bfa

I've added a setting under Experimental to enable/disable the feature (default: off). The feature may be good enough for first release :)

gave92 avatar May 01 '24 13:05 gave92

I had some notes on this but I'll have another look since it's been a while.

yaira2 avatar May 01 '24 18:05 yaira2

The main point to figure out before merging is whether the terminal is global, or if there can be a separate terminal for each tab & pane. I lean towards the second option (similar to VS Code).

yaira2 avatar May 01 '24 18:05 yaira2

Holding off while @hez2010 checks if it's possible to use Windows Terminal control.

gave92 avatar May 02 '24 06:05 gave92

Added ability to have more than one terminal 😇

gave92 avatar May 08 '24 22:05 gave92

Switching between terminals is working nicely!

yaira2 avatar May 08 '24 22:05 yaira2