Files icon indicating copy to clipboard operation
Files copied to clipboard

Code Quality: Remove App.Interacts namespace

Open 0x5bfa opened this issue 1 year ago • 1 comments

Code Quality: Remove App.Interacts namespace

Motivation & Context

  • Add more RichCommands from Interacts.

PR Checklist

  • [x] Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers. Related #4180
  • [x] Did you build the app and test your changes?
  • [ ] Did you check for accessibility? You can use Accessibility Insights for this.
  • [ ] Did you remove any strings from the en-us resource file?
    • [ ] Did you search the solution to see if the string is still being used?
  • [ ] Did you implement any design changes to an existing feature?
    • [ ] Was this change approved?
  • [ ] Are there any other steps that were used to validate these changes?

Screenshots

None

0x5bfa avatar Jun 24 '23 15:06 0x5bfa

Done. Ready for final review.

0x5bfa avatar Jun 26 '23 15:06 0x5bfa

@d2dyno1 said we should wait converting to Actions. Should I do just moving away to the appropriate places(to Data.Models & to ViewModels)? @yaira2

0x5bfa avatar Jul 06 '23 15:07 0x5bfa

Is there any reason to wait? Aside from a couple questions, this looks like it's ready.

yaira2 avatar Jul 06 '23 23:07 yaira2

If there's anything blocking - skip it; if not, I think we're in the clear to continue

d2dyno1 avatar Jul 07 '23 21:07 d2dyno1