Files icon indicating copy to clipboard operation
Files copied to clipboard

Code Quality: Clean up DetailsLayoutBrowser related code

Open 0x5bfa opened this issue 1 year ago • 4 comments

Code Quality: Clean up DetailsLayoutBrowser related code

Refactored before I work on columns refactoring, so I and you can understand quickly and easily how various content views do work.

If you see terrible diff, you can take a look at following classes to see what's going on.

  • https://github.com/0x5bfa/Files/blob/5bfa/functionize-columnsview/src/Files.App/Views/LayoutModes/BaseLayout.cs
  • https://github.com/0x5bfa/Files/tree/5bfa/functionize-columnsview/src/Files.App/Views/LayoutModes/DetailsLayoutBrowser.xaml.cs

Motivation & Context

  • Improved readability

Warning
Please do not review code lines that I did not changed. I cannot make more diff. If there're more codes that are preferred to change, I will do that and mark that PR as the final one for that stage.

PR Checklist

  • [x] Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers. Related #4180
  • [x] Did you build the app and test your changes?
  • [ ] Did you check for accessibility? You can use Accessibility Insights for this.
  • [ ] Did you remove any strings from the en-us resource file?
    • [ ] Did you search the solution to see if the string is still being used?
  • [ ] Did you implement any design changes to an existing feature?
    • [ ] Was this change approved?
  • [ ] Are there any other steps that were used to validate these changes?

Screenshots

None

0x5bfa avatar Jun 22 '23 14:06 0x5bfa

If you think diff is messing up, please take a look at https://github.com/0x5bfa/Files/tree/5bfa/functionize-columnsview/src/Files.App/Views/LayoutModes/DetailsLayoutBrowser.xaml.cs to see what is going on.

PS, finished all shallow cleanup. Ready for review.

0x5bfa avatar Jun 22 '23 15:06 0x5bfa

OMG. @lukeblevins I wanna work on #12505 asap. When do you expect will #12601 finish? I can open a PR on your clone repo to remove all conflists that I made, though.

0x5bfa avatar Jun 22 '23 15:06 0x5bfa

Nice cleaning so far!

QuaintMako avatar Jun 23 '23 13:06 QuaintMako

Ready for final review.

0x5bfa avatar Jun 23 '23 13:06 0x5bfa

@0x5bfa can you resolve the merge conflicts?

yaira2 avatar Jul 09 '23 02:07 yaira2

I dont want keep this PR because I'm forgetting what I changed and I cannot guarantee my refactoring PR quality. Please let me close this (I'm not going to do here again tho).

0x5bfa avatar Jul 11 '23 05:07 0x5bfa