Files icon indicating copy to clipboard operation
Files copied to clipboard

Feature: Keep file previews to Preview tab, use Icons for details

Open mdtauk opened this issue 1 year ago • 1 comments

What feature or improvement do you think would benefit Files?

image

When selecting a text file, the contents should only be displayed on the preview text (and using some kind of container to show its a preview and not some bug with Files itself)

For images I think the thumbnail is fine, but perhaps with the filetype icon overlayed in the bottom right corner?

I would also suggest a monotype font for plain text files preview.

Requirements

  • Display thumbnail in details pane
  • Display preview in details pane

Files Version

2.4.85

Windows Version

Windows 11 (22H2): 22621

Comments

The details pane should be polished and elegant or people will just close it and not get to see additional functionality.

mdtauk avatar Jun 08 '23 02:06 mdtauk

Thanks for the feedback, this is a good idea.

yaira2 avatar Jun 08 '23 02:06 yaira2

@mdtauk is this the expected behavior? (Nevermind the bad icon resolution and text preview still unformated as requested, I want to make sure I have the expectations right.)

Sans titre

QuaintMako avatar Jul 03 '23 09:07 QuaintMako

I would like to find a way to do something with a TXT preview, so it looks less like an error. - But yes the Icon should be used for the details page, unless its an image file, where we should have a thumbnail with an icon in the corner.

mdtauk avatar Jul 03 '23 11:07 mdtauk

Something like this. Do we want to word wrap, or maintain "formatting"

image

EDIT: Example without word wrapping... image

mdtauk avatar Jul 03 '23 12:07 mdtauk

@yaira2 should the header with the name/extension for all files be as the mockup shown above? And be there for both details/preview?

QuaintMako avatar Jul 05 '23 09:07 QuaintMako

If that's what @mdtauk wants.

Unless anyone has any objections to it?

@yaira2 Are you happy about the formatting for text file previews? And do you have any thoughts on word wrapping on or off?

mdtauk avatar Jul 05 '23 15:07 mdtauk

@QuaintMako do you still have the proof of concept code you showed above?

yaira2 avatar Aug 30 '23 21:08 yaira2

Just a reminder this is still an issue image

mdtauk avatar Aug 30 '23 23:08 mdtauk

@QuaintMako do you still have the proof of concept code you showed above?

I still have it, yes. It can be found here.

QuaintMako avatar Aug 31 '23 19:08 QuaintMako

Avez-vous eu l'occasion d'examiner ce problème ? Cela devient un peu gênant car lorsque nous sélectionnons un fichier avec le panneau de prévisualisation ouvert en mode "Détails", il ralentit lorsque la prévisualisation se charge, ce qui ne devrait pas être le cas en mode "Détails".

Lukiluc29 avatar Oct 29 '23 16:10 Lukiluc29

@Lukiluc29 if you prefer, you can use stable which doesn't have the shell preview handler yet.

yaira2 avatar Oct 29 '23 17:10 yaira2

@Lukiluc29 if you prefer, you can use stable which doesn't have the shell preview handler yet.

I know, but I really like the new features in the current version, so I can't go back to an earlier version.

Lukiluc29 avatar Oct 29 '23 17:10 Lukiluc29

Avez-vous eu l'occasion d'examiner ce problème ? Cela devient un peu gênant car lorsque nous sélectionnons un fichier avec le panneau de prévisualisation ouvert en mode "Détails", il ralentit lorsque la prévisualisation se charge, ce qui ne devrait pas être le cas en mode "Détails".

I'm working at the moment on finishing the code for this issue. It should be done pretty soon.

QuaintMako avatar Oct 29 '23 20:10 QuaintMako

I'm working at the moment on finishing the code for this issue. It should be done pretty soon.

Awesome! You're doing amazing work.

Lukiluc29 avatar Oct 29 '23 20:10 Lukiluc29