Files icon indicating copy to clipboard operation
Files copied to clipboard

Feature: Display modal when there is an error connecting to network locations

Open Richard-HM opened this issue 4 years ago • 16 comments

Requirements

  • Display modal when there is an error connecting to network locations
  • Modal should have a "close" action
  • Modal should have a secondary "retry" action

Richard-HM avatar Jun 17 '20 23:06 Richard-HM

@DominikGajdos sure

yaira2 avatar Oct 07 '22 19:10 yaira2

Thanks

DominikGajdos avatar Oct 07 '22 19:10 DominikGajdos

Hi, @DominikGajdos What's the status?

baibhavKumar1 avatar May 18 '23 05:05 baibhavKumar1

Hi, can I work on this?

br1trs avatar Jul 01 '23 23:07 br1trs

@br1trs of course, I'll assign you the issue.

yaira2 avatar Jul 02 '23 02:07 yaira2

Hello, I would like to work on this :)

mariusfranzen avatar Nov 28 '23 13:11 mariusfranzen

@yaira2 I'm looking at the contribution guidelines, but I can't find anything about branch naming and what branch the new branch should be based on

mariusfranzen avatar Dec 04 '23 12:12 mariusfranzen

You need to fork Files first then you can name the branch whatever you want and base it on main.

Josh65-2201 avatar Dec 04 '23 12:12 Josh65-2201

Got it, thanks. This is the first open source project I'm working on, so I'm new to that kind of stuff :)

mariusfranzen avatar Dec 04 '23 12:12 mariusfranzen

Does anyone have an idea about how I can fake a network drive that won't connect, or how I can force the connection to a drive to fail the connection?

mariusfranzen avatar Dec 04 '23 13:12 mariusfranzen

You could try making a local drive share (Windows File Explorer > Drive properties > Share). Mapping the drive to Windows (Right click the network section > Map drive > Enter \\Computer name\share name) > un-share the drive so it doesn't exist anymore on the network.

Josh65-2201 avatar Dec 04 '23 13:12 Josh65-2201

A bit of a hassle, but it works! Thank you. One last question. Can you point me in the right direction in the code? What folder/project to look in at least? I have no familiarity in the folder and file structure

mariusfranzen avatar Dec 04 '23 13:12 mariusfranzen

I don't know as I don't work with the codebase. @yaira2 or @0x5bfa might know.

Josh65-2201 avatar Dec 04 '23 13:12 Josh65-2201

To clarify @yaira2 or @0x5bfa, I'm wondering where the actual UI code is. Where can I find the initialization of another modal for example?

mariusfranzen avatar Dec 11 '23 07:12 mariusfranzen

@mariusfranzen Modal is actually called ContentDialog. If you'd like to see an example of it you can see Files.App.Dialogs namespace, where there's a bunch of it. When you're gonna create a new one, you can create from the Visual Studio templates window.

0x5bfa avatar Dec 11 '23 08:12 0x5bfa

@0x5bfa I don't know how much help you guys are actually willing to provide, but I can't for the life of me figure out where in the code I should check if there has been a problem accessing the network location. I have tried multiple solutions, but nothing works like it should

mariusfranzen avatar Dec 28 '23 07:12 mariusfranzen