files-community
Bug: Failing to eject mounted iso
What feature or improvement do you think would benefit Files?
Hi
I noticed that when mounting an .iso image, you cannot remove the iso image disc when clicking eject. There should be an option to remove the image mount disc permanently.
This is the only concern I have when working with iso images using files.
Steps to repro
- Right click iso to mount it
- Right click the mounted drive in the sidebar and click eject
- Observe that the drive isn't ejected
Files Version
4.5.21
Windows Version
Windows 11 22H2 22621.963
Comments
No response
Hi, I tried to reproduce it, but I don't see a mount option when right click an .iso file.
Sorry, I can't still see it. I use the latest version from the source code.
I found that the flag IOCTL_STORAGE_EJECT_MEDIA we are using has been deprecated. Instead, should use CM_Request_Device_Eject.
Hi all!
I'm new to this repo but would like to give this a go, where should I look in the repo for this issue?
I'm also able to build the project and reproduce this issue.
I guess this issue is too complex for new bee because this requires lower layer's win32 api
I was planning to fix this issue when merging all drive/device functions into IStorageRemovableDrivesService in #14572
But you can find the problem code in EjectAsync in RemovableDevice in Files.App.Data.Models.
I see, I did not realize it would be like that. I shall leave it in more experienced hands as I do not have experience with lower layer APIs.
Thanks for the response anyways!
@TcPirate1 When you have time you definitely can try out.
Fyi, we have project board, which enumerates all ready-to-build issue including bug fixes and feature requests. It also has size and priority of issues, enabling contributors to find easy-to-work issues. https://github.com/orgs/files-community/projects/3/views/7?sortedBy%5Bdirection%5D=desc&sortedBy%5BcolumnId%5D=13947857