Files
Files copied to clipboard
files-community
Convert FileOperationsHandler + FileTagsHandler to helpers
Resolved / Related Issues Items resolved / related issues by this PR.
- Related #4180.
- Related #9858
Validation How did you test these changes?
- [x] Built and ran the app
- [ ] Tested the changes for accessibility
Screenshots (optional) Add screenshots here.
hmm, I don't think there's another process that's using this file
---> System.IO.IOException: The process cannot access the file 'C:\Users\itswi\AppData\Local\Packages\FilesDev_ykqwq8d6ps0ag\LocalState\filetags.db' because it is being used by another process.
Can you verify is Files still able to launch? I cannot launch Files on my computer with this PR anymore, it hangs in the background constantly.
Can you verify is Files still able to launch? I cannot launch Files on my computer with this PR anymore, it hangs in the background constantly.
Works for me, dunno why it shouldn't work for you
Works for me, dunno why it shouldn't work for you
Did you try deploying a Release package and running it?
May related: https://github.com/files-community/Files/pull/10031 Will test again after that PR merged.
May related: https://github.com/files-community/Files/pull/10031 Will test again after that PR merged.
Can confirm it's #10031.
Other findings:
- Paste: doesn't work
- Delete: doesn't work
- Property-Security: doesn't work
- Create items: doesn't work
hmm, I don't think there's another process that's using this file
---> System.IO.IOException: The process cannot access the file 'C:\Users\itswi\AppData\Local\Packages\FilesDev_ykqwq8d6ps0ag\LocalState\filetags.db' because it is being used by another process.
This is expected becuase now we are trying to open filetags.db across multiple Files instances, which is not supported by LiteDB. You can leave this problem as is and open a new issue for it. We need to use something like mutex to make sure there's only one connection simultaneously, and synchronize the database operations across multiple instances.
Properties - Details doesn't work. When paste or delete multiple files, the "ongoing task" doesn't reflect the process properly. Paste and Delete still doesn't work if there're multiple Files instances running simultaneously.
Properties - Details doesn't work.
I can reproduce this even when building from the main branch so doesn't seem related to this PR.
When paste or delete multiple files, the "ongoing task" doesn't reflect the process properly. Paste and Delete still doesn't work if there're multiple Files instances running simultaneously.
Will take a look. EDIT: Attempting to fix that issue results in a crash with the same filetags.db problem, I don't really know how to fix it.
@itsWindows11 almost ready to look at this, can you resolve the merge conflicts?
Doesn't look like a build error I can fix; I can compile the app on my end.
