Files
Files copied to clipboard
Feature: Enhancing Restoring & Emptying the recycle bin.
Resolved / Related Issues
- Closes #9561
What has been done
- Added Restore action to recycle bin flyout when nothing is selected.
- Added Restore action to inner toolbar in recycle bin.
- Added Empty / Restore selection in inner toolbar.
- Added Empty selection to flyout when items are selected.
- Move Restore/Delete code
from src/Files.App/Interacts/BaseLayoutCommandImplementationModel.cs
tosrc/Files.App/Interacts/BaseLayoutCommandImplementationModel.cs
Validation How did you test these changes?
- [X] Built and ran the app
- [ ] Tested the changes for accessibility
Screenshots (optional)
The option to "Empty Selection" is a bit redundant as there is already the delete option.
The option to "Empty Selection" is a bit redundant as there is already the delete option.
It is indeed, but it's something that was asked for during the previous PR for that issue : https://github.com/files-community/Files/pull/9795#issuecomment-1230346893.
I can remove it if it's no longer asked for.
My apologies, I wasn't accounting for the existing delete option at the time.
Alright, so nuking it?
Yeah
Got it.
Should the "Empty Recycle Bin" button disappear from the toolbar when selecting items? Leaving just the "Restore Selection" one.
I think that should always be visible
Somehow the last merge done using Github interface messed up the project generation. Looking into it.
EDIT: Coming from the merge on the localization files apparently. Will fix it during the day most likely.
That should do it. The "Empty Selection" action has been fully removed and the merge issues have been fixed.
This might work for the restore icon 
Changed the restore icon, the one proposed it way better.