Files icon indicating copy to clipboard operation
Files copied to clipboard

Feature: Enhancing Restoring & Emptying the recycle bin.

Open QuaintMako opened this issue 2 years ago • 11 comments

Resolved / Related Issues

  • Closes #9561

What has been done

  • Added Restore action to recycle bin flyout when nothing is selected.
  • Added Restore action to inner toolbar in recycle bin.
  • Added Empty / Restore selection in inner toolbar.
  • Added Empty selection to flyout when items are selected.
  • Move Restore/Delete code from src/Files.App/Interacts/BaseLayoutCommandImplementationModel.cs to src/Files.App/Interacts/BaseLayoutCommandImplementationModel.cs

Validation How did you test these changes?

  • [X] Built and ran the app
  • [ ] Tested the changes for accessibility

Screenshots (optional)

Toolbar

Selection

SelectionFlyout

flyout

QuaintMako avatar Sep 16 '22 12:09 QuaintMako

The option to "Empty Selection" is a bit redundant as there is already the delete option.

yaira2 avatar Sep 16 '22 14:09 yaira2

The option to "Empty Selection" is a bit redundant as there is already the delete option.

It is indeed, but it's something that was asked for during the previous PR for that issue : https://github.com/files-community/Files/pull/9795#issuecomment-1230346893.

I can remove it if it's no longer asked for.

QuaintMako avatar Sep 16 '22 14:09 QuaintMako

My apologies, I wasn't accounting for the existing delete option at the time.

yaira2 avatar Sep 16 '22 15:09 yaira2

Alright, so nuking it?

QuaintMako avatar Sep 16 '22 15:09 QuaintMako

Yeah

yaira2 avatar Sep 16 '22 15:09 yaira2

Got it.

Should the "Empty Recycle Bin" button disappear from the toolbar when selecting items? Leaving just the "Restore Selection" one.

QuaintMako avatar Sep 16 '22 15:09 QuaintMako

I think that should always be visible

yaira2 avatar Sep 16 '22 15:09 yaira2

Somehow the last merge done using Github interface messed up the project generation. Looking into it.

EDIT: Coming from the merge on the localization files apparently. Will fix it during the day most likely.

QuaintMako avatar Sep 19 '22 06:09 QuaintMako

That should do it. The "Empty Selection" action has been fully removed and the merge issues have been fixed.

QuaintMako avatar Sep 19 '22 09:09 QuaintMako

This might work for the restore icon 

yaira2 avatar Sep 20 '22 01:09 yaira2

Changed the restore icon, the one proposed it way better.

QuaintMako avatar Sep 20 '22 13:09 QuaintMako