filer icon indicating copy to clipboard operation
filer copied to clipboard

Issue698

Open pbrahmbhatt3 opened this issue 6 years ago • 3 comments

issue123: I have changed all the constants that were declared using var to const.

pbrahmbhatt3 avatar Jan 29 '19 22:01 pbrahmbhatt3

Codecov Report

Merging #705 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #705   +/-   ##
=======================================
  Coverage   86.71%   86.71%           
=======================================
  Files          16       16           
  Lines        1746     1746           
=======================================
  Hits         1514     1514           
  Misses        232      232
Impacted Files Coverage Δ
src/filesystem/implementation.js 83.72% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 26b47ee...491104b. Read the comment docs.

codecov-io avatar Jan 29 '19 22:01 codecov-io

Awesome work. You seem to have left some variable as var. i recommend to use let

abdiG avatar Jan 31 '19 00:01 abdiG

Good job, but i'll suggest to add 'use strict'; to your files.

otkach avatar Jan 31 '19 02:01 otkach