ref-fvm icon indicating copy to clipboard operation
ref-fvm copied to clipboard

Syscall Testing Epic

Open Stebalien opened this issue 2 years ago • 1 comments

See https://github.com/filecoin-project/ref-fvm/pull/584 for an example:

  • [ ] ipld
    • [ ] block_open
    • [x] block_read
    • [ ] block_create
    • [ ] block_stat
    • [ ] block_link
  • [ ] self
    • [ ] root
    • [ ] set_root
    • [ ] current_balance
    • [ ] self_destruct
  • [ ] actor
    • [ ] resolve_address
    • [ ] get_actor_code_cid
    • [ ] new_actor_address
    • [ ] create_actor
    • [ ] get_builtin_actor_type
  • [ ] crypto
    • [ ] verify_signature
    • [ ] hash
    • [ ] compute_unsealed_sector_cid
    • [ ] verify_consensus_fault test with mocked extern?
    • ~verify_seal~ (requires params)
    • ~verify_post~ (requires params)
    • ~verify_replica_update~ (requires params)
    • ~verify_aggregate_seal~ (requires params)
    • ~batch_verify_seals~ (requires params)
  • [ ] rand - test with mocked externs?
  • [ ] send

Stebalien avatar May 19 '22 23:05 Stebalien

Things to check for:

  • Invalid arguments are correctly caught.
  • Correct error codes are returned.
  • Invariants are maintained (delete actor twice, delete, then set root, etc.).

Stebalien avatar May 19 '22 23:05 Stebalien

@Stebalien Do we want to work on this in M2.1?

maciejwitowski avatar Oct 07 '22 12:10 maciejwitowski

M2.1.5? This can land after we start the audits, but this is some important testing debt.

Stebalien avatar Oct 07 '22 14:10 Stebalien