lotus icon indicating copy to clipboard operation
lotus copied to clipboard

Verified Deals under 1MiB will break all deals in a publish message.

Open Reiers opened this issue 3 years ago • 0 comments

Checklist

  • [X] This is not a security-related bug/issue. If it is, please follow please follow the security policy.
  • [X] This is not a question or a support request. If you have any lotus related questions, please ask in the lotus forum.
  • [X] This is not a new feature request. If it is, please file a feature request instead.
  • [X] This is not an enhancement request. If it is, please file a improvement suggestion instead.
  • [X] I have searched on the issue tracker and the lotus forum, and there is no existing related issue or discussion.
  • [X] I am running the Latest release, or the most recent RC(release canadiate) for the upcoming release or the dev branch(master), or have an issue updating to any of these.
  • [X] I did not make any code changes to lotus.

Lotus component

  • [ ] lotus daemon - chain sync
  • [ ] lotus miner - mining and block production
  • [ ] lotus miner/worker - sealing
  • [ ] lotus miner - proving(WindowPoSt)
  • [X] lotus miner/market - storage deal
  • [ ] lotus miner/market - retrieval deal
  • [ ] lotus miner/market - data transfer
  • [ ] lotus client
  • [ ] lotus JSON-RPC API
  • [ ] lotus message management (mpool)
  • [ ] Other

Lotus Version

Daemon:  1.11.2-rc1+mainnet+git.80624845c+api1.3.0
Local: lotus version 1.11.2-rc1+mainnet+git.80624845c

Describe the Bug

Issue:

  Receiving a verified(Fil+) deals under 1MiB will break the entire publish message. 
  All the deals in that Batch will fail because of it. 

Expected behaviour:

The miner or markets node should reject all deals that are consensus-impossible.
No matter what other settings/configs you have set on the miner. 

Logging Information

2021-08-27T22:01:06.286+0200	INFO	markets	loggers/loggers.go:20	storage provider event	{"name": "ProviderEventFundsReleased", "proposal CID": "bafyreidfdtl5ydgnp6tr3aim7lmhh2q5fnodwkv5x7wexxltwmcyuz7bwm", "state": "StorageDealFailing", "message": "error calling node: publishing deal: GasEstimateMessageGas error: estimating gas used: message execution failed: exit 16, reason: failed to add verified deal for client: f3vnq2cmwig3qjisnx5hobxvsd4drn4f54xfxnv4tciw6vnjdsf5xipgafreprh5riwmgtcirpcdmi3urbg36a (RetCode=16)"}
2021-08-27T22:01:06.288+0200	INFO	markets	loggers/loggers.go:20	storage provider event	{"name": "ProviderEventFailed", "proposal CID": "bafyreigpu4mszaf5j2y6rnpzpilg2u53invagju4d7izm5wtyf5witglii", "state": "StorageDealError", "message": "error calling node: publishing deal: GasEstimateMessageGas error: estimating gas used: message execution failed: exit 16, reason: failed to add verified deal for client: f3vnq2cmwig3qjisnx5hobxvsd4drn4f54xfxnv4tciw6vnjdsf5xipgafreprh5riwmgtcirpcdmi3urbg36a (RetCode=16)"}
2021-08-27T22:01:06.300+0200	INFO	markets	loggers/loggers.go:20	storage provider event	{"name": "ProviderEventFailed", "proposal CID": "bafyreidfdtl5ydgnp6tr3aim7lmhh2q5fnodwkv5x7wexxltwmcyuz7bwm", "state": "StorageDealError", "message": "error calling node: publishing deal: GasEstimateMessageGas error: estimating gas used: message execution failed: exit 16, reason: failed to add verified deal for client: f3vnq2cmwig3qjisnx5hobxvsd4drn4f54xfxnv4tciw6vnjdsf5xipgafreprh5riwmgtcirpcdmi3urbg36a (RetCode=16)"}
2021-08-27T22:01:06.340+0200	INFO	markets	loggers/loggers.go:20	storage provider event	{"name": "ProviderEventFundsReleased", "proposal CID": "bafyreihk2rrr3abzllblf7apdzn3cdgqlnab2go26qljjfq5oyzq7v2tua", "state": "StorageDealFailing", "message": "error calling node: publishing deal: GasEstimateMessageGas error: estimating gas used: message execution failed: exit 16, reason: failed to add verified deal for client: f3vnq2cmwig3qjisnx5hobxvsd4drn4f54xfxnv4tciw6vnjdsf5xipgafreprh5riwmgtcirpcdmi3urbg36a (RetCode=16)"}
2021-08-27T22:01:06.346+0200	INFO	markets	loggers/loggers.go:20	storage provider event	{"name": "ProviderEventFailed", "proposal CID": "bafyreihk2rrr3abzllblf7apdzn3cdgqlnab2go26qljjfq5oyzq7v2tua", "state": "StorageDealError", "message": "error calling node: publishing deal: GasEstimateMessageGas error: estimating gas used: message execution failed: exit 16, reason: failed to add verified deal for client: f3vnq2cmwig3qjisnx5hobxvsd4drn4f54xfxnv4tciw6vnjdsf5xipgafreprh5riwmgtcirpcdmi3urbg36a (RetCode=16)"}
2021-08-27T22:01:06.766+0200	INFO	markets	loggers/loggers.go:20	storage provider event	{"name": "ProviderEventFundsReleased", "proposal CID": "bafyreia7ybvr25rgviz7oqhmomieehwvx6g5sndx7izsngweefdznt5de4", "state": "StorageDealFailing", "message": "error calling node: publishing deal: GasEstimateMessageGas error: estimating gas used: message execution failed: exit 16, reason: failed to add verified deal for client: f3vnq2cmwig3qjisnx5hobxvsd4drn4f54xfxnv4tciw6vnjdsf5xipgafreprh5riwmgtcirpcdmi3urbg36a (RetCode=16)"}
2021-08-27T22:01:06.779+0200	INFO	markets	loggers/loggers.go:20	storage provider event	{"name": "ProviderEventFailed", "proposal CID": "bafyreia7ybvr25rgviz7oqhmomieehwvx6g5sndx7izsngweefdznt5de4", "state": "StorageDealError", "message": "error calling node: publishing deal: GasEstimateMessageGas error: estimating gas used: message execution failed: exit 16, reason: failed to add verified deal for client: f3vnq2cmwig3qjisnx5hobxvsd4drn4f54xfxnv4tciw6vnjdsf5xipgafreprh5riwmgtcirpcdmi3urbg36a (RetCode=16)"}

Repo Steps

  1. Run '...'
  2. Do '...'
  3. See error '...' ...

Reiers avatar Aug 27 '21 20:08 Reiers