lotus icon indicating copy to clipboard operation
lotus copied to clipboard

gas tracing: OnIpldViewEnd needs to increase the skip

Open raulk opened this issue 4 years ago • 4 comments

The "gas charging blockstore" traces the line in code where the gas is being deducted, for later analysis. However, the View method adds an extra frame in the stack, therefore we need to increase the skip by 1 (total 2) to get an accurate trace.

https://github.com/filecoin-project/lotus/blob/1f754bdb78329d54c6c1b27deaa9f5c20cb443b7/chain/vm/vm.go#L89

raulk avatar Nov 13 '20 12:11 raulk

@raulk mind adding some description?

jennijuju avatar Jan 19 '21 11:01 jennijuju

@Kubuxu will get to this one time permits.

jennijuju avatar Apr 19 '21 16:04 jennijuju

@Kubuxu Can you update me on the progress here? 😂

rjan90 avatar Apr 14 '24 16:04 rjan90

I am quite sure this is outdated at this point, but it should be investigated. @arajasek could you spend some cycles on this?

Kubuxu avatar Apr 15 '24 16:04 Kubuxu