lotus
lotus copied to clipboard
gas tracing: OnIpldViewEnd needs to increase the skip
The "gas charging blockstore" traces the line in code where the gas is being deducted, for later analysis. However, the View method adds an extra frame in the stack, therefore we need to increase the skip by 1 (total 2) to get an accurate trace.
https://github.com/filecoin-project/lotus/blob/1f754bdb78329d54c6c1b27deaa9f5c20cb443b7/chain/vm/vm.go#L89
@raulk mind adding some description?
@Kubuxu will get to this one time permits.
@Kubuxu Can you update me on the progress here? 😂
I am quite sure this is outdated at this point, but it should be investigated. @arajasek could you spend some cycles on this?