lotus icon indicating copy to clipboard operation
lotus copied to clipboard

[DX Streamline] `make` additional targets in CI

Open rvagg opened this issue 7 months ago • 0 comments

Ref: https://github.com/filecoin-project/lotus/pull/12229

Not the first time docker builds have failed but we didn't know until after merge. Example of failure: https://github.com/filecoin-project/lotus/actions/runs/9941575020/job/27460958653

For some reason, perhaps lost to time, make buildall which is run in the Dockerfile, includes the testground target, which compiles to /dev/null. 🤷. But this pulls in build_testground.go with its configuration of variables and we didn't know it was broken until this was done in CI. But we can break other network builds as well, debug, butterflynet, calibnet, interopnet as well which can all break. Debug is less likely to break because we use 2k in integration tests. But we should have make for each of these targets just to be sure they comple.

rvagg avatar Jul 16 '24 04:07 rvagg