lotus icon indicating copy to clipboard operation
lotus copied to clipboard

FIP-0074: CLI to invoke the new SettleDealPayments method

Open arajasek opened this issue 1 year ago • 4 comments

SPs will now need to invoke this method in order to settle deal payment. The lotus-miner should expose functionality to do so.

This method will be similar to, and should be placed alongside, the existing actorWithdrawCmd (here), which performs a similar operation.

arajasek avatar Jan 22 '24 19:01 arajasek

needs https://github.com/filecoin-project/go-state-types/issues/239

jennijuju avatar Feb 19 '24 12:02 jennijuju

@arajasek @jennijuju Can you please confirm if there is an existing idea about how to create the bitfield for the params? I am just trying to figure out which deals to include in params. I can filter out based on provider but how do I ensure that I am not including the deals which are not going to result in anything and just waste the gas. Or is my assumption about the waste of gas wrong here?

LexLuthr avatar Feb 23 '24 16:02 LexLuthr

@LexLuthr are you still planning to work on this?

I would included two levels of granularity. First just filter by provider id. The gas costs shouldn't be significant in the common case. Second users can provide a list of deal ids if they really want fine grained control.

ZenGround0 avatar Apr 15 '24 17:04 ZenGround0

@ZenGround0 I won't be able to work on this at this time.

LexLuthr avatar Apr 16 '24 18:04 LexLuthr

Hey @rjan90 Can I work on this?

akaladarshi avatar Jul 17 '24 08:07 akaladarshi

Hey @akaladarshi,

Feel free to take this on. If you have any questions or need guidance, don't hesitate to ask here on GitHub or in the #fil-lotus-dev channel on Filecoin Slack.

rjan90 avatar Jul 17 '24 08:07 rjan90

Hey @rjan90, I have raised a draft PR for now. Please review it and let me know if this is the correct implementation.

I am little bit confused about payments for the deal, it was mentioned in FIP-0074 that the gas fee will be paid by the invoker of the function.

akaladarshi avatar Jul 20 '24 12:07 akaladarshi