go-fil-markets Paginate & filter storage client list-deals

Paginate & filter storage client list-deals

Open aarshkshah1992 opened this issue 4 years ago • 7 comments

For https://github.com/filecoin-project/lotus/issues/4185.

Mar 24 '21 09:03 aarshkshah1992

@dirkmc This has unit tests now. Can merge if all looks good.

Mar 24 '21 13:03 aarshkshah1992

@dirkmc

Have written the unit tests for the pagination as well.

Mar 25 '21 06:03 aarshkshah1992

Let's not merge right now as we're in the middle of testing a release, and I want to make sure the variadic arguments work across the API boundary.

Mar 25 '21 08:03 dirkmc

@dirkmc How dod you fix the imports here ?

Mar 26 '21 04:03 aarshkshah1992

Do we need to change the signature of ListLocalDeals so that it doesn't take variadic params?

Apr 01 '21 11:04 dirkmc

@dirkmc @aarshkshah1992 do we still want to land this? Looks like we paused for a previous release and didn't pick this back up.

Jun 14 '21 16:06 jacobheun

@aarshkshah1992 could you please resolve the conflicts and merge this? Lets aiming to merge this in lotus v1.11.1!

Jul 05 '21 16:07 jennijuju