eudico icon indicating copy to clipboard operation
eudico copied to clipboard

feat: B2 pikachu: integration of KVS and Bitcoin testnet and some refactoring

Open sa8 opened this issue 3 years ago • 2 comments

Related Issues

#102 #103 #117 #55

Proposed Changes

  • Changed initialisation of checkpointing
  • Changed the flow of the code (following feedback from @adlrocha)
  • Added bitcoin testnet integration (with the possibility to easily switch between regtest and testnet for testing purpose)
  • Changed the storage from MinIO to a local KVS
  • Rebased from main eudico branch

Additional Info

More information about the projects can be found here: https://github.com/protocol/ConsensusLab/issues/5

Checklist

Before you mark the PR ready for review, please make sure that:

  • [x] All commits have a clear commit message.
  • [x] The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • [x] This PR has tests for new functionality or change in behaviour
  • [ ] If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • [ ] CI is green

sa8 avatar Mar 22 '22 17:03 sa8

@sa8, do you mind pointing us to the right files to review (or pay more attention to)? There are 632 files changed 🙈 I guess this is as a result of your rebase with eudico (main) and the fact that your destination branch is not rebased. Thanks!

adlrocha avatar Mar 22 '22 17:03 adlrocha

ha yes of course 😅. The main one is chain/checkpointing/sub.go and chain/checkpointing/kvs.go for the part about the KVS.

sa8 avatar Mar 22 '22 18:03 sa8