dagstore icon indicating copy to clipboard operation
dagstore copied to clipboard

vyzo's review of the dagstore

Open vyzo opened this issue 3 years ago • 1 comments

Haven't dived into the subdirectories yet.

vyzo avatar Aug 02 '21 11:08 vyzo

So far one minor bug (see comments inline) and one recommendation for refactoring: The task processing logic of the event loop should be extracted on its own method, which can then:

  • lock/defer unlock to avoid having a really long lock scope with a bunch of pasta in-between
  • return the next task and avoid the internaclCh indirection, which can now be removed altogether.

vyzo avatar Aug 02 '21 11:08 vyzo