dagstore icon indicating copy to clipboard operation
dagstore copied to clipboard

panic from bitswap usage during `Start`

Open distractedm1nd opened this issue 1 year ago • 0 comments

Because Bitswap does not have a Start/Stop interface, and the Dagstore does not lock the d.shards map on startup, there can be a panic on concurrent read/write to d.shards.

For the short term, we are locking the dagstore during the Start operation. Should this be upstreamed? Is it feasible to add some sort of Start/Stop interface to bitswap as a better long term solution?

distractedm1nd avatar May 23 '23 11:05 distractedm1nd