builtin-actors icon indicating copy to clipboard operation
builtin-actors copied to clipboard

Remove async handling of terminated deals from market actor

Open alexytsu opened this issue 1 year ago • 2 comments

This can only be done after synchronous terminations has gone live.

When that code goes live, it must still handle any deals scheduled for cleanup that haven't been processed by cron yet.

After synchronous terminations is live, it should be impossible to encounter terminated sectors asynchronously. All code paths other than on_miner_sector_terminate should not handle terminations (and error if marked-for-termination) sectors are encountered.

alexytsu avatar Aug 30 '23 04:08 alexytsu

Must be done after https://github.com/filecoin-project/builtin-actors/pull/1377 goes live and after all marked-for-termination deals are cleared from chain state.

alexytsu avatar Aug 30 '23 04:08 alexytsu

Relevant section of the code: https://github.com/filecoin-project/builtin-actors/blob/master/actors/market/src/lib.rs#L952-L975

This should be good after DEAL_UPDATES_INTERVAL or 30 days from the last upgrade. So this should be good for either of the next upgrades. Worth sanity checking the DOBE queue to check that we don't see any async terminations scheduled before we do this.

ZenGround0 avatar Jun 04 '24 15:06 ZenGround0