builtin-actors icon indicating copy to clipboard operation
builtin-actors copied to clipboard

Update the builtin actors to expose `create` entrypoints

Open sistemd opened this issue 1 year ago • 3 comments

WASM module level create functions were added in https://github.com/filecoin-project/ref-fvm/pull/1821, and this PR adds support for them in the builtin actors. Only the unit tests for each individual test are passing, as well as the integration tests in the ref-fvm repo. I'll update all of the other tests once I get some general approval on the approach taken in this PR and https://github.com/filecoin-project/ref-fvm/pull/1821.

sistemd avatar Jul 22 '23 22:07 sistemd

A skim looked ok to me, but I've tagged @Stebalien for detailed review.

Will there be a FIP for this VM change which discusses the design tradeoffs involved in the approach generally?

anorth avatar Jul 23 '23 22:07 anorth

There will absolutely be a FIP (and some discussion, we haven't landed on the final design yet). I'll review this and the related PRs this coming week.

Thanks @sistemd! :heart:

Stebalien avatar Jul 24 '23 03:07 Stebalien

Reverting to draft until the FIP etc

anorth avatar Dec 12 '23 01:12 anorth