builtin-actors icon indicating copy to clipboard operation
builtin-actors copied to clipboard

Remove deal/sector activation from cron

Open jennijuju opened this issue 1 year ago • 5 comments

  • Option A: Remove async proof validation - Drop ProveCommit and always use ProveAggregateSectors
  • Option B: Add an explicit activation step for all sectors that’s triggered by a message sent by SPS

A and B are mutually exclusive. If we do A, B less less useful in general. However, B is useful for SaaS/Inaactive CC sector providers.

jennijuju avatar Apr 10 '23 18:04 jennijuju

There is good discussion in https://github.com/filecoin-project/FIPs/discussions/689. I don't think the options are mutually exclusive.

For option A it is quite likely that using an aggregated proof wastes resources for proving a single sector, and we'll instead need a new method that uses non-aggregated proof but synchronously activates the sector.

Option B above is under-specified. I assume it doesn't mean changing the behaviour of the existing proof method across the board. It probably means some new methods that prove without activating. These can still be useful even with option A.

In any case the protocol design needs to be worked out in a draft FIP before we dive into code.

anorth avatar May 22 '23 23:05 anorth

For lotus/actor team - this will be a P3 & blocked until we have better understanding on projects like sector events/direct FIL+ given the design/scope/timeline dependencies.

jennijuju avatar Jun 13 '23 21:06 jennijuju

Note if a new ProveCommitBatch is added, that proves synchronously but without the overheads of proof aggregation, it will depend on https://github.com/filecoin-project/ref-fvm/issues/1852 for correct gas accounting.

anorth avatar Aug 22 '23 19:08 anorth

The new ProveCommit2 in #1380 will synchronously validate proofs. So after that is live, we can eventually solve this by deprecating the original (will require parties to move to direct onboarding flow, though that can still support deals).

anorth avatar Aug 23 '23 20:08 anorth

This will be FIP-0084

anorth avatar Jan 22 '24 21:01 anorth