FIPs icon indicating copy to clipboard operation
FIPs copied to clipboard

FIP-0086 Audit final changes

Open ranchalp opened this issue 10 months ago • 1 comments

Addressing design issues listed as ii. (partially) iii. iv. and vi. from go-f3's #177.

ranchalp avatar Apr 22 '24 16:04 ranchalp

@Kubuxu @masih @Stebalien just signalling this to you; covers the noted items in https://github.com/filecoin-project/go-f3/issues/177

jsoares avatar Apr 26 '24 09:04 jsoares

This looks good to me (just note the outstanding question from @anorth).

Did I not already addressed that comment (you mean this one I guess?) (I did not accept the commit suggestion, but made it in a new commit myself, as I was considering other changes).

Should we also include the proofs pdf in this PR?

We can. I have just accepted suggestions on the two docs that are IMO at their final versions (GossiPBFT Implementation v2, and GossiPBFT message rebroadcast v3, with the former referencing the later in a new section). Lmk if you would like me to do it or if you are waiting on Alex North or others to agree to this before doing it yourself (or have me do it). 🙂

ranchalp avatar May 09 '24 13:05 ranchalp

Did I not already addressed that comment (you mean https://github.com/filecoin-project/FIPs/pull/996#discussion_r1592942134 I guess?) (I did not accept the commit suggestion, but made it in a new commit myself, as I was considering other changes).

You hadn't when I started the review -- you had by the time I submitted it. I just resolved the discussion, no further action needed.

Let's sync in slack re pdfs.

jsoares avatar May 09 '24 13:05 jsoares