filebrowser
feat: Add context menu
New PR for #2871 updated to Vue3 https://github.com/filebrowser/filebrowser/pull/2871
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
I found a bug in the menu implementation. When you click the right button on a file for the second time, the file becomes unselected and then the menu opens for the entire folder.
https://github.com/user-attachments/assets/5751a903-899d-42bb-b334-dcdcc47b21f7
I found a bug in the menu implementation. When you click the right button on a file for the second time, the file becomes unselected and then the menu opens for the entire folder.
https://github.com/user-attachments/assets/5751a903-899d-42bb-b334-dcdcc47b21f7
This was an International feature since originally, a right click would still select/deselect an item on the list. If this isn't a feature that is preferred to have, I will address it in a commit soon.
I found a bug in the menu implementation. When you click the right button on a file for the second time, the file becomes unselected and then the menu opens for the entire folder.
screen.recording.movThis was an International feature since originally, a right click would still select/deselect an item on the list. If this isn't a feature that is preferred to have, I will address it in a commit soon.
I'd say it should select but not unselect a file. Otherwise, it's just confusing and looks buggy
First of all, thank you very much for your contribution. The context menu feature is very helpful to us and is very convenient to use. I immediately patched my code, but I found several problems during use:
- When right-clicking in a blank space, if no file or folder is selected,
downloadandinfowill appear, and it will conflict with the right-click of the browser; - When switching views, there will be only one column;
- The mouse position in the pop-up box that appears when right-clicking is too close, you can move it a little to one side;
- When checking the
Use single clicks to open files and directoriesoption, the user experience is slightly worse;
If you have any questions, please feel free to contact me. Thank you again for your contribution.
Screenshot
Code diff context_menu.diff.txt
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.
@o1egl Finally completed this issue, please let me know if any updates are still required
@ultwcz hope this commit resolves your issues, lmk
Ok, I will test it.
Thank you.
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.
@omalk98 I'd recommend reading the current project status when it comes to adding new features: https://github.com/filebrowser/filebrowser#project-status
@omalk98 I'd recommend reading the current project status when it comes to adding new features: https://github.com/filebrowser/filebrowser#project-status
Oh, that's a shame. It would have been great to get this merged.
