filebrowser
filebrowser copied to clipboard
Add HEIF support
Description
Add HEIF/HEIC support, a commonly used format with iPhones.
- [x] requesting to pull a topic/feature/bugfix branch
- [x] pull request against the master branch
- [x] File Browser can be successfully built (amd64 and arm64 tested)
- [x] no issues are opened in other repositories
- [x] continuous integration build passed
Further comments
This is an experimental change and may lead to more maintenance overhead than desired. Anyway, I wanted to try it out and gather some feedback.
It builds successfully on linux/amd64
and linux/arm64
It also builds on darwin/amd64
with warnings.
It is able to read images 1-3 from https://github.com/tigranbs/test-heic-images but it segfaults for image 4.
Now the following questions arise:
- Is it a generally embraced addition?
- Is it possible to catch the SIGSEGV?
- Should target architectures be conditionally included?
Would be a great feature to have!
Here's my vote for HEIC support.
Would be a great feature to have in filebrowser.
👍🏻 for this feature!
+1 on this feature, please merge.
This feature adds a dependency on CGO. With that our existing release pipeline will be broken. It cannot be merged without rewriting the build pipeline to support CGO cross-compilation.
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.
This PR was closed because it has been stalled for 5 days with no activity.