filebrowser icon indicating copy to clipboard operation
filebrowser copied to clipboard

Add HEIF support

Open adrium opened this issue 3 years ago • 6 comments

Description

Add HEIF/HEIC support, a commonly used format with iPhones.

  • [x] requesting to pull a topic/feature/bugfix branch
  • [x] pull request against the master branch
  • [x] File Browser can be successfully built (amd64 and arm64 tested)
  • [x] no issues are opened in other repositories
  • [x] continuous integration build passed

Further comments

This is an experimental change and may lead to more maintenance overhead than desired. Anyway, I wanted to try it out and gather some feedback.

It builds successfully on linux/amd64 and linux/arm64 It also builds on darwin/amd64 with warnings.

It is able to read images 1-3 from https://github.com/tigranbs/test-heic-images but it segfaults for image 4.

Now the following questions arise:

  1. Is it a generally embraced addition?
  2. Is it possible to catch the SIGSEGV?
  3. Should target architectures be conditionally included?

adrium avatar Mar 29 '21 20:03 adrium

Would be a great feature to have!

jniggemann avatar Oct 27 '21 10:10 jniggemann

Here's my vote for HEIC support.

PLK2 avatar Mar 14 '22 00:03 PLK2

Would be a great feature to have in filebrowser.

pushpinderbal avatar Mar 31 '22 03:03 pushpinderbal

👍🏻 for this feature!

gaby avatar Apr 19 '22 00:04 gaby

+1 on this feature, please merge.

TCB13 avatar Jun 25 '22 13:06 TCB13

This feature adds a dependency on CGO. With that our existing release pipeline will be broken. It cannot be merged without rewriting the build pipeline to support CGO cross-compilation.

o1egl avatar Aug 29 '22 17:08 o1egl

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Sep 29 '22 02:09 github-actions[bot]

This PR was closed because it has been stalled for 5 days with no activity.

github-actions[bot] avatar Oct 05 '22 02:10 github-actions[bot]