filament icon indicating copy to clipboard operation
filament copied to clipboard

Compatibility with blade-ui-kit/blade-heroicons 2.*

Open nocodelab opened this issue 1 year ago • 3 comments

Package

filament/notifications

Package Version

2.0

Laravel Version

9.28.0

Livewire Version

2.10.7

PHP Version

8.1

Problem description

The dependency to blade-ui-kit/blade-heroicons should be updated to 2.* to support the new heroicons version (2).

Expected behavior

The installation should complete succesfully.

Steps to reproduce

composer require blade-ui-kit/blade-heroicons:"^2.0" composer require filament/notifications:"^2.0"

Reproduction repository

https://github.com/blade-ui-kit/blade-heroicons

Relevant log output

Problem 1
    - filament/notifications[v2.15.1, ..., 2.x-dev] require blade-ui-kit/blade-heroicons ^1.2 -> found blade-ui-kit/blade-heroicons[1.2.0, 1.2.1, 1.3.0, 1.3.1] but it conflicts with your root composer.json require (^2.0).
    - Root composer.json requires filament/notifications ^2.0 -> satisfiable by filament/notifications[v2.15.1, ..., 2.x-dev].

Use the option --with-all-dependencies (-W) to allow upgrades, downgrades and removals for packages currently locked to specific versions.

Installation failed, reverting ./composer.json and ./composer.lock to their original content.

nocodelab avatar Sep 09 '22 08:09 nocodelab

@nocodelab This won't have until version 3.x of Filament because it's considered a breaking change for existing applications using renamed / removed icons in the new version of Heroicons.

ryangjchandler avatar Sep 09 '22 09:09 ryangjchandler

Additionally, we can't upgrade to v2 of the Blade Heroicons package, since it dropped support for Laravel 8.

Closing this issue, as it's already being tracked on our v3 roadmap: https://github.com/orgs/filamentphp/projects/2/views/1.

zepfietje avatar Sep 09 '22 09:09 zepfietje

Reopening this so people stop asking

danharrin avatar Sep 09 '22 10:09 danharrin

Done for v3: https://github.com/filamentphp/filament/issues/4490.

zepfietje avatar Oct 14 '22 14:10 zepfietje