filament icon indicating copy to clipboard operation
filament copied to clipboard

Markdown editor doesn't get a red border upon validation errors

Open Cannonb4ll opened this issue 3 years ago • 2 comments

Package

filament/forms

Package Version

v2.0.0

Laravel Version

v9.0.0

Livewire Version

No response

PHP Version

PHP 8.1

Bug description

The markdown editor does not have a red border when a validation error occurs like inputs or selects.

Upon investigation with @danharrin we noticed wire:ignore is the cause of this:

https://github.com/laravel-filament/filament/blob/417e359c7023ed2b9cba319eb3529b16a456b47c/packages/forms/resources/views/components/markdown-editor.blade.php#L17

Removing that line fixes the $error state, but introduces a error within action modals.

Steps to reproduce

No response

Relevant log output

No response

Cannonb4ll avatar May 12 '22 08:05 Cannonb4ll

Can you test out #2404? There are a few other issues but most have been fixed I think

danharrin avatar May 12 '22 12:05 danharrin

As far as I can see and test seems all good!

Cannonb4ll avatar May 16 '22 06:05 Cannonb4ll

#3649

tanthammar avatar Aug 24 '22 13:08 tanthammar