filament icon indicating copy to clipboard operation
filament copied to clipboard

Extract theme logic to global store and apply theme to button tooltips

Open pxlrbt opened this issue 2 years ago • 11 comments

  • Extract theme logic to a global store.
  • Change button/cell tooltip theme based on global theme

pxlrbt avatar Mar 23 '22 10:03 pxlrbt

Please fix the merge conflict :)

danharrin avatar Mar 23 '22 13:03 danharrin

Done.

pxlrbt avatar Mar 23 '22 13:03 pxlrbt

Do these tooltips work outside of the admin panel now?

danharrin avatar Mar 23 '22 14:03 danharrin

I don't think so. I only added the theme logic to it. If they didn't work before they probably won't work now.

pxlrbt avatar Mar 23 '22 15:03 pxlrbt

They did work before, but I wonder how the theming logic that isnt available outside the admin affects that

danharrin avatar Mar 23 '22 16:03 danharrin

Ah ... damn didn't think about that. I am only using the admin panel.

pxlrbt avatar Mar 23 '22 16:03 pxlrbt

Ah ... damn didn't think about that. I am only using the admin panel.

Not expecting you to work further on fixing this if you're not actively benefiting from your work, but I need to mark this as Draft so that I remember to do some work on it myself if you don't want to.

danharrin avatar Mar 23 '22 22:03 danharrin

@danharrin As I have no experience with the Form and Table Builder as separate packages I'll leave this up to you.

pxlrbt avatar Mar 24 '22 09:03 pxlrbt

What's required for this PR to move forward?

zepfietje avatar Jul 18 '22 17:07 zepfietje

Currently, this solution only works for the admin panel, but not for the forms package. I don't have any experience with the standalone forms package, therefore I didn't continue work on this. I guess the main issue was detecting dark/light mode on the forms package.

pxlrbt avatar Jul 18 '22 17:07 pxlrbt

Hmm yeah, so we basically need the theme logic in the packages as well? 🤔

Did you already think of a solution, @danharrin?

zepfietje avatar Jul 18 '22 20:07 zepfietje

Gonna close this, since it's quite far behind main and needs to be reworked taking into account recent changes. We need to find a solution for the subpackages as well.

danharrin avatar Sep 16 '22 10:09 danharrin