filament
filament copied to clipboard
Extract theme logic to global store and apply theme to button tooltips
- Extract theme logic to a global store.
- Change button/cell tooltip theme based on global theme
Please fix the merge conflict :)
Done.
Do these tooltips work outside of the admin panel now?
I don't think so. I only added the theme logic to it. If they didn't work before they probably won't work now.
They did work before, but I wonder how the theming logic that isnt available outside the admin affects that
Ah ... damn didn't think about that. I am only using the admin panel.
Ah ... damn didn't think about that. I am only using the admin panel.
Not expecting you to work further on fixing this if you're not actively benefiting from your work, but I need to mark this as Draft so that I remember to do some work on it myself if you don't want to.
@danharrin As I have no experience with the Form and Table Builder as separate packages I'll leave this up to you.
What's required for this PR to move forward?
Currently, this solution only works for the admin panel, but not for the forms package. I don't have any experience with the standalone forms package, therefore I didn't continue work on this. I guess the main issue was detecting dark/light mode on the forms package.
Hmm yeah, so we basically need the theme logic in the packages as well? 🤔
Did you already think of a solution, @danharrin?
Gonna close this, since it's quite far behind main
and needs to be reworked taking into account recent changes. We need to find a solution for the subpackages as well.