Feat: list translations command option
Description
This PR introduces a new option for 'check-translations' command for Filament 4.x. The 'check-translations' command helps to find missing and deleted translations. You need to see all translations to find all errors, like typos and changed English strings. You can list all translations with new --list option.
(Related unmerged PR.)
Functional changes
Example usage: list Filament hungarian translations:
php artisan filament:check-translations hu --list
Command output:
- [x] Code style has been fixed by running the
composer cscommand. - [x] Changes have been tested to not break existing functionality.
- [x] Documentation is up-to-date.
@danharrin I can resolve the conflict. Am I allowed to do it?
Yes please :)
@danharrin Here is a new conflict. The file '02-contributing.md' has been moved to another directory (01-introduction) and renamed in 4.x branch. Should I create a new PR and close this PR?
If you can leave it in the same branch that would be fine, I don't think we need a new PR if you can handle the conflict here
I'm not sure, but I think these commands (in the updated local repository) resolve the conflict. Right?
git checkout check-trans-4.x
mkdir docs/01-introduction
git mv docs/10-about/02-contributing.md docs/01-introduction/05-contributing.md
git add .
git commit -m "Move contributing.md"
git push origin check-trans-4.x
The original file was updated though. Don't worry about it, I will fix the conflict myself before merge.
Thank you very much!
I'll review this within this week, sorry for the delay on this one.
Hey @saade, do you have time to review this?
@danharrin Is there anyone else to review?
@VasasA I already reviewed it — your code needs to be refactored before it can be merged. Right now, lack of spare time is what’s preventing me from doing it.
@danharrin You're free to merge/ take the lead on this, i'll only be able to review it in May.
@saade I'm happy to wait for your review, theres no real rush :)
Hey @VasasA, I wrote a new tool to check stuff around translations and which can be run from the Filament repo directly. Can you check #16426 and give feedback whether that works for you?
Thanks Dennis, I think that will work great. And thanks again for your work @VasasA