filament icon indicating copy to clipboard operation
filament copied to clipboard

Feat: list translations command option

Open VasasA opened this issue 11 months ago • 12 comments

Description

This PR introduces a new option for 'check-translations' command for Filament 4.x. The 'check-translations' command helps to find missing and deleted translations. You need to see all translations to find all errors, like typos and changed English strings. You can list all translations with new --list option. (Related unmerged PR.)

Functional changes

Example usage: list Filament hungarian translations:

php artisan filament:check-translations hu --list

Command output: kép

  • [x] Code style has been fixed by running the composer cs command.
  • [x] Changes have been tested to not break existing functionality.
  • [x] Documentation is up-to-date.

VasasA avatar Jan 03 '25 20:01 VasasA

@danharrin I can resolve the conflict. Am I allowed to do it?

VasasA avatar Feb 09 '25 15:02 VasasA

Yes please :)

danharrin avatar Feb 09 '25 17:02 danharrin

@danharrin Here is a new conflict. The file '02-contributing.md' has been moved to another directory (01-introduction) and renamed in 4.x branch. Should I create a new PR and close this PR?

VasasA avatar Feb 22 '25 20:02 VasasA

If you can leave it in the same branch that would be fine, I don't think we need a new PR if you can handle the conflict here

danharrin avatar Feb 22 '25 21:02 danharrin

I'm not sure, but I think these commands (in the updated local repository) resolve the conflict. Right?

git checkout check-trans-4.x
mkdir docs/01-introduction
git mv docs/10-about/02-contributing.md docs/01-introduction/05-contributing.md
git add .
git commit -m "Move contributing.md"
git push origin check-trans-4.x

VasasA avatar Feb 22 '25 23:02 VasasA

The original file was updated though. Don't worry about it, I will fix the conflict myself before merge.

danharrin avatar Feb 22 '25 23:02 danharrin

Thank you very much!

VasasA avatar Feb 22 '25 23:02 VasasA

I'll review this within this week, sorry for the delay on this one.

saade avatar Feb 23 '25 22:02 saade

Hey @saade, do you have time to review this?

danharrin avatar Apr 02 '25 09:04 danharrin

@danharrin Is there anyone else to review?

VasasA avatar Apr 29 '25 18:04 VasasA

@VasasA I already reviewed it — your code needs to be refactored before it can be merged. Right now, lack of spare time is what’s preventing me from doing it.

@danharrin You're free to merge/ take the lead on this, i'll only be able to review it in May.

saade avatar Apr 29 '25 19:04 saade

@saade I'm happy to wait for your review, theres no real rush :)

danharrin avatar Apr 29 '25 19:04 danharrin

Hey @VasasA, I wrote a new tool to check stuff around translations and which can be run from the Filament repo directly. Can you check #16426 and give feedback whether that works for you?

pxlrbt avatar Jun 08 '25 18:06 pxlrbt

Thanks Dennis, I think that will work great. And thanks again for your work @VasasA

danharrin avatar Jun 09 '25 08:06 danharrin