Feature: Uncontained Fieldset
Description
Closes #11355. This has to be discussed with @zepfietje before merging
Visual changes
Functional changes
- [x] Code style has been fixed by running the
composer cscommand. - [x] Changes have been tested to not break existing functionality.
- [x] Documentation is up-to-date.
Please check #14968 for how I implemented it in the Section, with the -not- class instead, and using the CanBeContained trait.
Please check #14968 for how I implemented it in the Section, with the
-not-class instead, and using theCanBeContainedtrait.
Will do. Thanks
The reason I want the -not class is because my philosophy is that an element should have a minimal number of CSS classes to achieve the "default" look, so if someone uses the raw classes instead of the Blade component they can achieve it easier.
Please add more space between the legend and the content, I think it needs to at least look the same as
gap-6But I would like to hear what Zep's idea was for this, as I don't think I'd ever use an uncontained fieldset
Unfortunately gap wont work because we're using the display: block property which prevents gap from having an effect. Instead I used padding-top which in this case I believe has the same result.
Hey @zepfietje, is there any update on this?
@thethunderturner could you share screenshots of the current state of this PR?
@thethunderturner could you share screenshots of the current state of this PR?
Will do!