filament icon indicating copy to clipboard operation
filament copied to clipboard

Feature: Uncontained Fieldset

Open thethunderturner opened this issue 1 year ago • 7 comments

Description

Closes #11355. This has to be discussed with @zepfietje before merging

Visual changes

image image

Functional changes

  • [x] Code style has been fixed by running the composer cs command.
  • [x] Changes have been tested to not break existing functionality.
  • [x] Documentation is up-to-date.

thethunderturner avatar Dec 02 '24 14:12 thethunderturner

Please check #14968 for how I implemented it in the Section, with the -not- class instead, and using the CanBeContained trait.

danharrin avatar Dec 02 '24 15:12 danharrin

Please check #14968 for how I implemented it in the Section, with the -not- class instead, and using the CanBeContained trait.

Will do. Thanks

thethunderturner avatar Dec 02 '24 15:12 thethunderturner

The reason I want the -not class is because my philosophy is that an element should have a minimal number of CSS classes to achieve the "default" look, so if someone uses the raw classes instead of the Blade component they can achieve it easier.

danharrin avatar Dec 02 '24 15:12 danharrin

Please add more space between the legend and the content, I think it needs to at least look the same as gap-6

But I would like to hear what Zep's idea was for this, as I don't think I'd ever use an uncontained fieldset

Unfortunately gap wont work because we're using the display: block property which prevents gap from having an effect. Instead I used padding-top which in this case I believe has the same result.

thethunderturner avatar Dec 02 '24 16:12 thethunderturner

Hey @zepfietje, is there any update on this?

thethunderturner avatar Dec 19 '24 13:12 thethunderturner

@thethunderturner could you share screenshots of the current state of this PR?

zepfietje avatar Apr 18 '25 06:04 zepfietje

@thethunderturner could you share screenshots of the current state of this PR?

Will do!

thethunderturner avatar Apr 18 '25 07:04 thethunderturner