filament icon indicating copy to clipboard operation
filament copied to clipboard

fix: update resource namespace option in commands

Open wotta opened this issue 1 year ago • 1 comments

Description

Added the missing option to set the resource namespace when calling make:filament-resource using the Artisan::call method.

Maybe a bit unusual PR but I ran into this while creating some functionality and have "clusters" enabled. While this is enabled I couldn't programmatically run this command anymore because there was no way of adding that option thus getting errors. This change resolves it for me.

Visual changes

No visual changes unless you want a screenshot of the new command options. Just let me know😁

Functional changes

  • [x] Code style has been fixed by running the composer cs command.
  • [x] Changes have been tested to not break existing functionality.
  • [x] Documentation is up-to-date.

wotta avatar Sep 28 '24 14:09 wotta

Instead of this flag that just selects the first, shouldnt there be an argument where you pass in the name of the namespace, like the model namespace, so you can select a cluster if you need that? Because I find this PR quite confusing as a true/false option

danharrin avatar Oct 07 '24 12:10 danharrin

Hi, the CLI has now been refactored for v4, so if you want to implement this please put it on that branch, with the suggested change above too

danharrin avatar Dec 02 '24 17:12 danharrin